Skip to content

[Backport] Fixed issue #22788 #22906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2019
Merged

[Backport] Fixed issue #22788 #22906

merged 1 commit into from
May 20, 2019

Conversation

mahesh-rajawat
Copy link
Member

Original Pull Request

#22791
Fixed issue #22788 New Shipment emails do not generate

Preconditions (*)

  1. Magento 2.3.1 Open Source
  2. Ubuntu 16.04, PHP 7.2, Apache 2.4.18

Steps to reproduce (*)

  1. Go to Marketing > Email Templates
  2. Add Template
  3. Load magento_sales > New Shipment (Default Template with no custom changes)
  4. Press Load
  5. Preview Template

Expected result (*)

  1. The Template Preview Tab loads with the default contents

Actual result (*)

  1. The Template Preview Tab is blank. The only HTML source code is below
<html lang="en"><head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
    <title>Email Preview</title>
</head>
<body>
    </body>
</html>

Further Notes: When you remove the below line from the Default Template, the Template Preview loads:

{{block class='Magento\\Framework\\View\\Element\\Template' area='frontend' template='Magento_Sales::email/shipment/track.phtml' shipment=$shipment order=$order}}

template-ok

@m2-assistant
Copy link

m2-assistant bot commented May 15, 2019

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch dmytro-ch self-requested a review May 15, 2019 18:41
@dmytro-ch dmytro-ch self-assigned this May 15, 2019
@VasylShvorak VasylShvorak self-assigned this May 20, 2019
@Nazar65 Nazar65 self-assigned this May 20, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@magento-engcom-team magento-engcom-team mentioned this pull request May 20, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit a387566 into magento:2.2-develop May 20, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 20, 2019

Hi @maheshWebkul721, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request May 20, 2019
@VladimirZaets
ENGCOM-5127: [Backport] Fixed issue #22788 #22906
ad6b9ab
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@Nazar65 Nazar65

@dmytro-ch dmytro-ch

@VasylShvorak VasylShvorak

Labels
Area: Frontend Component: Sales Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.10
Development

Successfully merging this pull request may close these issues.
6 participants
@mahesh-rajawat @VasylShvorak @dmytro-ch @Nazar65 @magento-engcom-team @gaurav-473