Skip to content

Fix Elasticsearch category page issues when 1 column layout is used #24630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

arendarenko
Copy link
Contributor

@arendarenko arendarenko commented Sep 17, 2019

Description (*)

This changes fixes issue #24619

Fixed Issues (if relevant)

  1. Elasticsearch category page issues when 1 column layout is used #24619: Elasticsearch category page issues when 1 column layout is used

Manual testing scenarios (*)

  1. Choose category with products and set 1 column design to it (Catalog -> Categories -> Edit Category -> Design -> Layout -> "1 column"
  2. Save category
  3. Flush cache
  4. Open this category on website and change sort order to "Price"
  5. Go to page 2

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

unset pagesize after loading collection in order to prevent issues with limits during next collection usages
@arendarenko arendarenko requested a review from kokoc as a code owner September 17, 2019 14:09
@m2-assistant
Copy link

m2-assistant bot commented Sep 17, 2019

Hi @alexeya-ven. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@arendarenko arendarenko changed the title Module Layered Navigation fixes Fix Elasticsearch category page issues when 1 column layout is used Sep 17, 2019
@ghost ghost assigned ihor-sviziev Sep 17, 2019
@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 17, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5854 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

Copy link
Contributor

@engcom-Foxtrot engcom-Foxtrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @alexeya-ven.
I don't think we can accept this PR.
First of all, this change would affect not only Elasticsearch, but any other search engine, and that may cause some unpredictable problems in the future.
Secondly, the bug is caused by Magento\LayeredNavigation\Block\Navigation\Category element order: in 1 column layout, it is rendered before \Magento\Catalog\Block\Category\View, while in other layouts render order is reversed.

@arendarenko
Copy link
Contributor Author

Hi @engcom-Foxtrot
Thanks for reply. Unfortunately, I don't have time to investigate this issue deeper.

@m2-assistant
Copy link

m2-assistant bot commented Sep 30, 2019

Hi @alexeya-ven, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants