-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix Elasticsearch category page issues when 1 column layout is used #24630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
unset pagesize after loading collection in order to prevent issues with limits during next collection usages
Hi @alexeya-ven. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @ihor-sviziev, thank you for the review. |
✔️ QA passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, @alexeya-ven.
I don't think we can accept this PR.
First of all, this change would affect not only Elasticsearch, but any other search engine, and that may cause some unpredictable problems in the future.
Secondly, the bug is caused by Magento\LayeredNavigation\Block\Navigation\Category element order: in 1 column layout, it is rendered before \Magento\Catalog\Block\Category\View, while in other layouts render order is reversed.
Hi @engcom-Foxtrot |
Hi @alexeya-ven, thank you for your contribution! |
Description (*)
This changes fixes issue #24619
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)