Added ability generate unsecure URL if current URL is secure #10244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When calling getUrl from a secure connection ( HTTPS ) with param _secure = false we are getting secure URL instead of unsecured.
Fixed Issues (if relevant)
Manual testing scenarios
Preconditions
Magento 2 version 2.3.0-dev
Use \Magento\Framework\Url::getUrl() from secure area of the store
###Steps to reproduce
Make sure code is executed in secure area of the store (HTTPS)
Generate URL in code
/**
* @var \Magento\Framework\Url
*/
protected $url;
...
$this->url->getUrl(
'test/test/test',
[
'_secure' => false
]
)
Expected result
http://example.com/test/test/test
Contribution checklist