Skip to content

Change 'Update'-button visibility on change qty event. #14935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

likemusic
Copy link
Contributor

Description

When qty value in minicat updated by js, Update-button should have the same behavior like when qty is manually edited.

Fixed Issues (if relevant)

Manual testing scenarios

  1. jQuery('.cart-item-qty:first').val(parseFloat(jQuery('.cart-item-qty:first').val()) - 1).change(); - Update button should be shown.
  2. jQuery('.cart-item-qty:first').val(parseFloat(jQuery('.cart-item-qty:first').val()) - 1).change(); - Update button should be hidden.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@VladimirZaets
Copy link
Contributor

Hi @likemusic , I took your PR into processing, thank you for collaboration.

@magento-engcom-team
Copy link
Contributor

Hi @likemusic. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants