Skip to content

[Backport] Change 'Update'-button visibility on change qty event #15104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented May 9, 2018

Original PR: #14935.

Description

When qty value in minicat updated by js, Update-button should have the same behavior like when qty is manually edited.

Manual testing scenarios

jQuery('.cart-item-qty:first').val(parseFloat(jQuery('.cart-item-qty:first').val()) - 1).change(); - Update button should be shown.
jQuery('.cart-item-qty:first').val(parseFloat(jQuery('.cart-item-qty:first').val()) - 1).change(); - Update button should be hidden.

@sergiy-v sergiy-v requested a review from rogyar May 9, 2018 12:11
@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 9, 2018
@magento-engcom-team magento-engcom-team added Release Line: 2.1 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept labels May 9, 2018
@magento-engcom-team magento-engcom-team merged commit 45b8f87 into magento:2.1-develop May 12, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sergiy-v. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

@sergiy-v sergiy-v deleted the feature/2.1-minicart-update-button branch February 28, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants