check if order data is available to incl ec

[torhoehn]

Description

After merging #13034 ecommerce tracking wasn't working, because it's not possible to call length on an object (ordersTrackingData).

Fixed Issues (if relevant)

1. Google analytics pageview being triggered twice #12221: Google analytics pageview being triggered twice (see comment Google analytics pageview being triggered twice #12221 (comment))

Manual testing scenarios

1. Created a Google Analytics test account
2. Order something
3. Order will appear in Google Analytics (Conversion -> E-Commerce) or see console with running Google Analytics Debugger (https://chrome.google.com/webstore/detail/google-analytics-debugger/jnkmfdileelhofjcijamephohjechhna). Transfered data will contain product specific data.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

@torhoehn thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

Hi @torhoehn. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

[sashas777]

If someone need temporary fix for the version 2.2.4 with the assumption that it would be fixed in the newest release. Feel free to use it: https://github.com/sashas777/magento224-issue14951

This made based on PR by @torhoehn - all thanks to him

[peterjaap]

@sashas777 why does that work only with 2.2.4 and not with 2.2.3?

[sashas777]

@peterjaap I applied fix based on version 2.2.4 and didn't test for any other versions. This is only the reason

[asadyar]

Google Analytics tracking is still missing in Magento 2.2.6 composer update from 2.2.5

Is there any deadline or temporary fix available for this.

Thanks,

[torhoehn]

@asadyar The change from this PR is present in 2.2.6.

[asadyar]

Thanks torhoehn, I clear and flush Magento 2 cache, I can see its triggering the Google Analytics event on success page.

Thanks,
Best Regards,
Asad

[asadyar]

Thanks Torben, I tested this in Magento 2.2.6 and its working fine. Best regards Asad

…

On Mon, 1 Oct 2018 at 13:43, Torben Höhn ***@***.***> wrote: @asadyar <https://github.com/asadyar> The change from this PR is present in 2.2.6. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15765 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFjFOoc6bDLLxp1xc0QlvNqV-oZC-Mj_ks5uglQlgaJpZM4UY44a> .

[nickpiro]

Should I be fine making this update in 2.2.5 instead up updating to 2.2.6?

[torhoehn]

@nickpiro Yes, it'll work for 2.2.5, too. E.g. copy the .js-file to your theme and make the change.

[nickpiro]

@torhoehn I updated the one in vendor with this file and it still does not work! :/

[torhoehn]

@nickpiro Feel free to contact me on Slack: https://tinyurl.com/engcom-slack