Skip to content

[Up-port] check if order data is available to incl ec #15847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2018
Merged

[Up-port] check if order data is available to incl ec #15847

merged 1 commit into from
Jun 7, 2018

Conversation

torhoehn
Copy link
Contributor

@torhoehn torhoehn commented Jun 5, 2018

Description

Original pull request: #15765

Fixed Issues (if relevant)

  1. Google analytics pageview being triggered twice #12221: Google analytics pageview being triggered twice (see comment Google analytics pageview being triggered twice #12221 (comment))

Manual testing scenarios

  1. Created a Google Analytics test account
  2. Order something
  3. Order will appear in Google Analytics (Conversion -> E-Commerce) or see console with running Google Analytics Debugger (https://chrome.google.com/webstore/detail/google-analytics-debugger/jnkmfdileelhofjcijamephohjechhna). Transfered data will contain product specific data.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@torhoehn torhoehn deleted the up-port-pull-15765 branch June 7, 2018 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants