Skip to content

[Correct code formatting] #15811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hitesh-wagento
Copy link
Contributor

This PR is a:

  • Bug fix or improvement

Summary

Correct Code formatting.

Additional information

NA

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jun 5, 2018
@orlangur orlangur self-assigned this Jun 5, 2018
@orlangur
Copy link
Contributor

orlangur commented Jun 5, 2018

Hi @hitesh-wagento, please combine all PRs with fixing indentation in LESS files into a single PR.

Also, please check why it is not enforced by phpcs currently.

@hitesh-wagento
Copy link
Contributor Author

hitesh-wagento commented Jun 5, 2018

@orlangur , Yes now I am create only one PR for all coding related changes in Blank theme. Previously I think no more changes occurred so I have created multiple PRs.

@orlangur
Copy link
Contributor

orlangur commented Jun 5, 2018

@hitesh-wagento please add all changes related to indentation changes in Luma, Blank or wherever else here.

Please check why phpcs didn't catch this violation also, it would be nice so that such kind of mistake nevermore occurs.

@hitesh-wagento
Copy link
Contributor Author

ok, Let me create one new PR with luma and blank both changes.

@orlangur
Copy link
Contributor

orlangur commented Jun 5, 2018

@hitesh-wagento just force push into this branch 😉

@hitesh-wagento
Copy link
Contributor Author

hitesh-wagento commented Jun 5, 2018

@orlangur I have pushed my changes in multishipping-module-less-patch branch. Do we need to create Forwardport and Backport PR again ?

@hitesh-wagento
Copy link
Contributor Author

Hello @orlangur

Any update in this PR ?

Thanks

@orlangur
Copy link
Contributor

H @hitesh-wagento, please do the same with #15813 - force push into it - after this PR is merged. No need to create a PR for 2.1.

@hitesh-wagento
Copy link
Contributor Author

Hi @orlangur

I have pushed my changes in #15813

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-1959 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Cleanup Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants