Skip to content

[Forwardport] [Correct code formatting] #16260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hitesh-wagento
Copy link
Contributor

Original Pull Request

#15811

This PR is a:

  • Bug fix or improvement

Summary

Correct Code formatting.

Additional information

NA

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Area: Design/Frontend labels Jun 20, 2018
@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@ishakhsuvarov
Copy link
Contributor

ishakhsuvarov commented Jun 20, 2018

Hi @hitesh-wagento
This Pull Request contains 4 commits with no message. This is not acceptable.
Please squash all of the changes into a single commit and accompany it with a message

@hitesh-wagento
Copy link
Contributor Author

@ishakhsuvarov

I have created forwardport using Port tool didn't commit different files.

@ishakhsuvarov
Copy link
Contributor

@hitesh-wagento Porting tool was created only to assist in some cases, however, it's not guaranteed to produce correct result. It is considered to be PR author's responsibility to fix anything which may be incorrect.

@hitesh-wagento hitesh-wagento deleted the 2.3-develop-PR-port-15811 branch September 6, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants