Skip to content

[Forwordport2.3] Fix incorrect type hinting in PHPDocs #16122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 45 commits into from
Closed

[Forwordport2.3] Fix incorrect type hinting in PHPDocs #16122

wants to merge 45 commits into from

Conversation

chirag-wagento
Copy link
Contributor

Original Pull Request

#15619

Description

Incorrect PHPdoc causes warnings in IDE.

Changes applied:

  1. Changed the return type for setQty method to the type it actually returns.
  2. Removed the hint for newer thrown LocalizedException in PHPDocs of register and setQty methods.

Fixed Issues

  1. Incorrect phpdoc should be Shipment\Item not Invoice\Item #13992: Incorrect phpdoc should be Shipment\Item not Invoice\Item

Manual testing scenarios

  1. This is not necessary, this just resolves warnings in the IDE.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

chirag-wagento and others added 30 commits June 5, 2018 04:19
[Forwardport] Removed unused class from forms less file.
[Forwardport] [BUGFIX] Added row_id to the flat action indexer so the value isn't s…
[Forwardport] Fixed set template syntax issue
[Forwardport] Solve overlapping Issue on every Home page & category page of Hot Sel…
removed extraneous margin and compensated padding and set both to 0, which creates the same effect
- Removed unnecessary menu item called Magento_Catalog::inventory. The title of the tab in browser no is set to "Products / Catalog / Magento Admin" rather than "Products / Inventory / Catalog / Magento Admin".
[Forwardport] Removed unnecessary menu item called Magento_Catalog::inventory in Magento_Catalog.
[Forwardport] #13354 - [Improvement] Add HTML attributes to containers
[Forwardport] Small refactoring to better code readability
@magento-engcom-team
Copy link
Contributor

Hi @chirag-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@osrecio
Copy link
Member

osrecio commented Jun 14, 2018

Closing this PR. Check your trace of commits and create new PR.

@osrecio osrecio closed this Jun 14, 2018
@osrecio osrecio self-assigned this Jun 14, 2018
@chirag-wagento
Copy link
Contributor Author

Hello @osrecio

Sorry not getting you can you please explain me in brief.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants