Skip to content

Update Israeli ZIP code mask: 7 digits instead of 5 #16250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Update Israeli ZIP code mask: 7 digits instead of 5 #16250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Directory/etc/zip_codes.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@
</zip>
<zip countryCode="IL">
<codes>
<code id="pattern_1" active="true" example="12345">^[0-9]{5}$</code>
<code id="pattern_1" active="true" example="6687865">^[0-9]{7}$</code>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace example with realistic one please?

According to https://en.wikipedia.org/wiki/Postal_codes_in_Israel 5 digit zip codes are still widely used but unofficially, should we support both patterns for some time maybe?

Copy link
Contributor Author

@itaymesh itaymesh Jun 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example I used is a realistic one.
I think we should not support the old 5 digit format because it might cause a shipping bounce.

</codes>
</zip>
<zip countryCode="IT">
Expand Down