Skip to content

Update Israeli ZIP code mask: 7 digits instead of 5 #16250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2018
Merged

Update Israeli ZIP code mask: 7 digits instead of 5 #16250

merged 1 commit into from
Jun 22, 2018

Conversation

itaymesh
Copy link
Contributor

@itaymesh itaymesh commented Jun 19, 2018 •
edited
Loading

Description

The Israeli ZIP code format had changed 2 years ago.
Magento uses the 5 digits format. It's old and outdated.
The new format is 7 digits.

Manual testing scenarios

  1. add a product to cart
  2. go to the checkout page
  3. select Israel on shipping addreds country field
  4. enter the following zip code 6687865

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 19, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @itaymesh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@itaymesh itaymesh changed the title Update Israeli ZIP code mask, 7 digits instead of 5 ,according to the… Update Israeli ZIP code mask: 7 digits instead of 5 Jun 19, 2018
@orlangur orlangur self-assigned this Jun 20, 2018
orlangur
orlangur requested changes Jun 20, 2018
View reviewed changes
app/code/Magento/Directory/etc/zip_codes.xml
@@ -196,7 +196,7 @@
</zip>
<zip countryCode="IL">
<codes>
<code id="pattern_1" active="true" example="12345">^[0-9]{5}$</code>
<code id="pattern_1" active="true" example="6687865">^[0-9]{7}$</code>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace example with realistic one please?

According to https://en.wikipedia.org/wiki/Postal_codes_in_Israel 5 digit zip codes are still widely used but unofficially, should we support both patterns for some time maybe?

Copy link
Contributor Author

@itaymesh itaymesh Jun 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example I used is a realistic one.
I think we should not support the old 5 digit format because it might cause a shipping bounce.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jun 20, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2073 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@itaymesh thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit 6345bbd into magento:2.2-develop Jun 22, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 22, 2018
@IvanPletnyov
ENGCOM-2073: Update Israeli ZIP code mask: 7 digits instead of 5 #16250…
54ba409 
… (fix test)
magento-engcom-team pushed a commit that referenced this pull request Jun 22, 2018
ENGCOM-2073: Update Israeli ZIP code mask: 7 digits instead of 5 #16250
0ef05b1
@magento-engcom-team
Copy link
Contributor

Hi @itaymesh. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

This was referenced Jun 22, 2018
Closed
Closed
Closed
Closed
Closed
@viktym viktym mentioned this pull request Jun 23, 2018
Open
@sidolov sidolov mentioned this pull request Jun 26, 2018
Closed
4 tasks
This was referenced Jul 7, 2018
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

Labels
Component: Directory Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.6
Development

Successfully merging this pull request may close these issues.
4 participants
@itaymesh @magento-cicd2 @magento-engcom-team @orlangur