Skip to content

Fixed widget template rendering issue while rewriting widget block. #16530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanganinamrata
Copy link
Member

Description

Fixed template notation for Magento_CatalogWidget module.

Fixed Issues (if relevant)

Magento version 2.2.x

  1. Rewriting product listing widget block breaks its template rendering. #16529: Rewriting product listing widget block breaks its template rendering.2. ...

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @sanganinamrata. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@miguelbalparda
Copy link
Contributor

@sanganinamrata can you please check the failing tests?

@sanganinamrata
Copy link
Member Author

@miguelbalparda - Ok I'll check the failing tests soon and get back to you.

@sanganinamrata
Copy link
Member Author

@gelanivishal Thanks for the quick fix.

@sanganinamrata
Copy link
Member Author

@miguelbalparda : Failing test is fixed, Please have a look.

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-2211 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @sanganinamrata. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants