Skip to content

[Backport] Fixed widget template rendering issue while rewriting widget block #17111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2018
Merged

[Backport] Fixed widget template rendering issue while rewriting widget block #17111

merged 2 commits into from
Jul 26, 2018

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Jul 25, 2018 •
edited by sidolov
Loading

Original Pull Request

#16530

Description

Fixed template notation for Magento_CatalogWidget module.

Fixed Issues (if relevant)

Magento version 2.2.x

  1. Rewriting product listing widget block breaks its template rendering. #16529: Rewriting product listing widget block breaks its template rendering.2. ...

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@gelanivishal gelanivishal changed the title 2.1 develop pr port 16530 [Backport] Fixed widget template rendering issue while rewriting widget block Jul 25, 2018
@VladimirZaets VladimirZaets self-assigned this Jul 25, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jul 25, 2018
@sidolov sidolov mentioned this pull request Jul 26, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 784d167 into magento:2.1-develop Jul 26, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 26, 2018
ENGCOM-2518: [Backport] Fixed widget template rendering issue while r…
204fc73 
…ewriting widget block #17111
@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VladimirZaets VladimirZaets

Labels
Cleanup Component: CatalogWidget Component: Widget Progress: accept Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.15
Development

Successfully merging this pull request may close these issues.
4 participants
@gelanivishal @magento-engcom-team @VladimirZaets @sanganinamrata