Skip to content

[Backport] Update Israeli ZIP code mask, 7 digits instead of 5 ,according to the… #16795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request

#16250

Description

The Israeli ZIP code format had changed 2 years ago.
Magento uses the 5 digits format. It's old and outdated.
The new format is 7 digits.

Manual testing scenarios

  1. add a product to cart
  2. go to the checkout page
  3. select Israel on shipping addreds country field
  4. enter the following zip code 6687865

@sidolov
Copy link
Contributor

sidolov commented Jul 15, 2018

Hi @gelanivishal , please, take a look at failed tests:
Magento\Directory\Model\Country\Postcode\ValidatorTest::testPostCodes with data set #39 ('IL', '12345')

@sidolov sidolov self-assigned this Jul 15, 2018
@gelanivishal gelanivishal requested a review from orlangur July 23, 2018 10:16
@gelanivishal gelanivishal assigned orlangur and unassigned sidolov Jul 27, 2018
@orlangur orlangur added this to the Release: 2.1.15 milestone Jul 31, 2018
@orlangur
Copy link
Contributor

Closing due to inactivity. Feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened.

@orlangur orlangur closed this Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants