Skip to content

Update nginx.config.sample to exclude php5-fpm #16883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

sean-breeden
Copy link
Contributor

@sean-breeden sean-breeden commented Jul 17, 2018

Description

M2.2.x is not compatible with php5.x so there's no reason to include it as an option in the nginx.config.sample. Refer to: https://devdocs.magento.com/guides/v2.2/install-gde/system-requirements-tech.html

Fixed Issues (if relevant)

This does not fix any issues. However, it does prevent someone from thinking that M2.2.x is compatible with php5.

Manual testing scenarios

No tests needed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

M2.2.x is not compatible with php5.x so there's no reason to include it as an option in the nginx.config.sample
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 17, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @sean-wcb. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@miguelbalparda miguelbalparda self-assigned this Jul 17, 2018
@miguelbalparda
Copy link
Contributor

Thanks for your contribution @sean-wcb! I'll process this one and let you know if we have any questions.

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-2407 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@sean-wcb thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @sean-wcb. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants