Skip to content

[Forwardport] Update nginx.config.sample to exclude php5-fpm #17044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2018
Merged

[Forwardport] Update nginx.config.sample to exclude php5-fpm #17044

merged 1 commit into from
Jul 25, 2018

Conversation

torhoehn
Copy link
Contributor

@torhoehn torhoehn commented Jul 23, 2018

Original Pull Request

#16883

Description

M2.2.x is not compatible with php5.x so there's no reason to include it as an option in the nginx.config.sample. Refer to: https://devdocs.magento.com/guides/v2.2/install-gde/system-requirements-tech.html

Fixed Issues (if relevant)

This does not fix any issues. However, it does prevent someone from thinking that M2.2.x is compatible with php5.

Manual testing scenarios

No tests needed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

M2.2.x is not compatible with php5.x so there's no reason to include it as an option in the nginx.config.sample
@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Partner: Basecom partners-contribution Pull Request is created by Magento Partner labels Jul 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2493 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@torhoehn torhoehn deleted the 2.3-develop-PR-port-16883 branch July 25, 2018 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants