Skip to content

Fix wrong return type in StockRegistryInterface::getLowStockItems() API #17539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vasilii-b
Copy link

@vasilii-b vasilii-b commented Aug 11, 2018

Description

Full description in #15085.

Fixes wrong return type of StockRegistryInterface :: getLowStockItems() when using REST API /V1/stockItems/lowStock/

Fixed Issues (if relevant)

  1. StockRegistryInterface :: getLowStockItems() returns StockStatusCollection instead of StockItemCollection #15085

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@vasilii-b vasilii-b changed the title Fix wrong return type in StockRegistryInterface API Fix wrong return type in StockRegistryInterface::getLowStockItems() API Aug 11, 2018
@vasilii-b vasilii-b self-assigned this Aug 11, 2018
@vasilii-b vasilii-b requested a review from rogyar August 11, 2018 14:03
@rogyar
Copy link
Contributor

rogyar commented Aug 12, 2018

Hi @vasilii-b. Thank you for your commitment. According to the latest contributor guide (https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html) code cleanup should be performed in 2.3-develop branch. Please, create PR to the mentioned branch.
Thank you.

@rogyar rogyar closed this Aug 12, 2018
@vasilii-b
Copy link
Author

vasilii-b commented Aug 13, 2018

Hi @rogyar,
Thank you for update. PR for 2.3 was created - #17562

@vasilii-b vasilii-b deleted the 2.2-api-getLowStockItems-wrong-return-type branch August 13, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CatalogInventory Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants