Skip to content

Virtual-only quotes use default shipping address for estimation instead of default billing address #17744 fix #18084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

ericflemes
Copy link

@ericflemes ericflemes commented Sep 16, 2018

  - For the replacement of virtual products
  - Virtual-only quotes use default shipping address for estimation instead of default billing address #17744
 - Enter a billing address
 - Register a shipping address
 - Add a vidual product to cart
 - The address shown in the summary must be the billing address

  Second senary

  - Enter a billing address

  • Register a shipping address

  • Add a vidual product to cart

  • Add a simple product

  • The address shown in the summary must be the delivery address

  • The behavior is for the cart (View and Edit Cart)

Description

The selectBillingAddress was added when the product is virtual only

Fixed Issues (if relevant)

Was fixed only (Virtual-only quotes use default address for estimation instead of default billing address # 17744 fix)

  1. Virtual-only quotes use default shipping address for estimation instead of default billing address #17744: Issue Virtual-only quotes use default shipping address for estimation instead of default billing address

Manual testing scenarios

- Enter a billing address
- Register a shipping address
- Add a vidual product to cart
- The address shown in the summary must be the billing address

  Second senary
  • Enter a billing address
  • Register a shipping address
  • Add a vidual product to cart
  • Add a simple product
  • The address shown in the summary must be the delivery address

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Eric Lemes seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@magento-engcom-team magento-engcom-team added Partner: Webjump partners-contribution Pull Request is created by Magento Partner labels Sep 16, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ericflemes. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Eric Lemes added 2 commits September 16, 2018 17:05
@williankeller
Copy link
Member

Hi @ericflemes,
There is a similar pull request fixing same issue: #18095

@ishakhsuvarov ishakhsuvarov added this to the Release: 2.3.1 milestone Sep 18, 2018
@VladimirZaets VladimirZaets added Progress: needs update and removed partners-contribution Pull Request is created by Magento Partner labels Sep 18, 2018
@VladimirZaets VladimirZaets self-assigned this Sep 18, 2018
@VladimirZaets
Copy link
Contributor

Hi @ericflemes, please, sign CLA, otherwise, we can't process your pull request.
Please look failed JS unit and static tests.

@sidolov
Copy link
Contributor

sidolov commented Oct 2, 2018

Hi @ericflemes , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants