Skip to content

#17744 Adding logic to get default billing address used on Cart and Checkout #18095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 27, 2018
Merged

#17744 Adding logic to get default billing address used on Cart and Checkout #18095

merged 7 commits into from
Oct 27, 2018

Conversation

LucasCalazans
Copy link
Member

@LucasCalazans LucasCalazans commented Sep 17, 2018 •
edited
Loading

Description

Fixing the bug when the cart is virtual and the estimate was getting the shipping address instead billing address.

Fixed Issues

  1. Virtual-only quotes use default shipping address for estimation instead of default billing address #17744: Virtual-only quotes use default shipping address for estimation instead of default billing address

Manual testing scenarios

First scenario

  1. Register a billing and a shipping address (Diferents)
  2. Add a virtual product to cart
  3. The address used in the estimation must be the billing address

Second scenario

  1. Register a billing and a shipping address (Diferents)
  2. Add a virtual product to cart
  3. Add a simple product
  4. The address used in the estimation must be the shipping address

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @LucasCalazans. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@LucasCalazans
Copy link
Member Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @LucasCalazans. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @LucasCalazans, here is your new Magento instance.
Admin access: https://pr-18095.engcom.dev.magento.com/admin
Login: admin Password: 123123q

williankeller
williankeller reviewed Sep 17, 2018
View reviewed changes
app/code/Magento/Checkout/view/frontend/web/js/model/checkout-data-resolver.js Outdated

if (shippingAddress &&
if(quote.isVirtual()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LucasCalazans,
Please add space between ifand (.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @williankeller, thanks for your review, I've just added this alteration.

@williankeller williankeller mentioned this pull request Sep 17, 2018
Closed
4 tasks
@VladimirZaets VladimirZaets self-assigned this Sep 18, 2018
@ishakhsuvarov ishakhsuvarov added this to the Release: 2.3.1 milestone Sep 18, 2018
@VladimirZaets
Copy link
Contributor

Hi @LucasCalazans. Thanks for the collaboration. Please look failed JS unit and static tests.

@LucasCalazans
Copy link
Member Author

@VladimirZaets I've made the fixies on the branch and the tests passed.

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3219 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@LucasCalazans thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@sidolov sidolov mentioned this pull request Oct 27, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit f3bad34 into magento:2.3-develop Oct 27, 2018
@magento-engcom-team
Copy link
Contributor

Hi @LucasCalazans. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

magento-engcom-team pushed a commit that referenced this pull request Oct 27, 2018
ENGCOM-3219: #17744 Adding logic to get default billing address used …
6f7cf07 
…on Cart and Checkout #18095
@gelanivishal gelanivishal mentioned this pull request Oct 27, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williankeller williankeller williankeller left review comments

@VladimirZaets VladimirZaets VladimirZaets approved these changes

@michaelyu0123 michaelyu0123 Awaiting requested review from michaelyu0123

@omiroshnichenko omiroshnichenko Awaiting requested review from omiroshnichenko

@YevSent YevSent Awaiting requested review from YevSent

Assignees

@VladimirZaets VladimirZaets

Labels
Area: Frontend Award: bug fix Component: Braintree Component: Checkout Component: Paypal Partner: Webjump partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
5 participants
@LucasCalazans @magento-engcom-team @VladimirZaets @williankeller @ishakhsuvarov