-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[BAckport] Fix SKU limit in import new products #18869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BAckport] Fix SKU limit in import new products #18869
Conversation
Hi @gelanivishal. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @gelanivishal , changes in the original PR are different and should be adopted for current version |
@sidolov Please check now. |
@gelanivishal thanks for update, can you please fix the failing builds. According to the static tests report an empty line should be added to the end of app/code/Magento/CatalogImportExport/Model/Import/Product/Validator.php file. That should be done to comply with the PSR2 |
Hi @sivaschenko, thank you for the review. |
Hi @gelanivishal , thank you for your contribution, however, this pull request is a duplicate to #18591 that is already merged, so I have to close it. |
Original PR
#18639
Description (*)
Fix SKU limit in import new product
Fixed Issues (if relevant)
Manual testing scenarios (*)
prepare a correct csv to create new products via backend. Use short values (less then 71 characters) for name/sku for a few records, then use a longer strings ((more then 71 characters) for name/sku for other records.
go to system > import:
-- entity type = products
-- import behaviour = add/update, skip error entries
-- allow errors count = I tried with several numbers from 10 (default) to 500 but issue persists
-- field separator = ; (semicolon)
-- multiple value separator = , (comma, default)
-- field enclosure = unchecked (default)
Select the csv to import and run check data
when strings are too long, I expect to see an error after I run check data. I also expect that import get blocked until all error are fixed so no products gets created until the check data allows you to proceed with the import.
Contribution checklist (*)