Skip to content

[BAckport] Fix SKU limit in import new products #18869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

gelanivishal
Copy link
Contributor

Original PR

#18639

Description (*)

Fix SKU limit in import new product

Fixed Issues (if relevant)

  1. import new products via csv: products are created with empty value when strings are too long #17865: import new products via csv: products are created with empty value when strings are too long

Manual testing scenarios (*)

  1. prepare a correct csv to create new products via backend. Use short values (less then 71 characters) for name/sku for a few records, then use a longer strings ((more then 71 characters) for name/sku for other records.

  2. go to system > import:
    -- entity type = products
    -- import behaviour = add/update, skip error entries
    -- allow errors count = I tried with several numbers from 10 (default) to 500 but issue persists
    -- field separator = ; (semicolon)
    -- multiple value separator = , (comma, default)
    -- field enclosure = unchecked (default)

  3. Select the csv to import and run check data

  4. when strings are too long, I expect to see an error after I run check data. I also expect that import get blocked until all error are fixed so no products gets created until the check data allows you to proceed with the import.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov sidolov self-assigned this Oct 31, 2018
@sidolov
Copy link
Contributor

sidolov commented Oct 31, 2018

Hi @gelanivishal , changes in the original PR are different and should be adopted for current version

@gelanivishal
Copy link
Contributor Author

@sidolov Please check now.

@sivaschenko
Copy link
Member

@gelanivishal thanks for update, can you please fix the failing builds. According to the static tests report an empty line should be added to the end of app/code/Magento/CatalogImportExport/Model/Import/Product/Validator.php file. That should be done to comply with the PSR2

@sivaschenko sivaschenko added Progress: needs update Complex Review Complex review provided by Maintainer and removed Complex Review Complex review provided by Maintainer labels Nov 14, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 16, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3481 has been created to process this Pull Request

@sivaschenko
Copy link
Member

Hi @gelanivishal , thank you for your contribution, however, this pull request is a duplicate to #18591 that is already merged, so I have to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants