Skip to content

2.2.6 Use batches and direct queries to fix sales address upgrade #18945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

2.2.6 Use batches and direct queries to fix sales address upgrade #18945

wants to merge 5 commits into from

Conversation

rikwillems
Copy link
Contributor

Description (*)

Magento Commerce compatible fix for sales address upgrade script.

Fixed Issues (if relevant)

  1. [update] enhance performance on large catalog #16570: enhance performance on large catalog
    (comment)

@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


**** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@magento-engcom-team
Copy link
Contributor

Hi @rikwillems. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev ihor-sviziev self-assigned this Oct 30, 2018
@ihor-sviziev
Copy link
Contributor

Hi @rikwillems,
Please sign CLA, otherwise we can't accept your PR

@rikwillems
Copy link
Contributor Author

@ihor-sviziev I did that and see it reflected in the ticket now.

@ihor-sviziev
Copy link
Contributor

Hi @rikwillems,
Here is some failures in static and integration tests, looks like there is some issue in your implementation. Could you looks on it?

Your implementation actually not so easy. Could you describe how your solution works to be sure we're on the same page?

@rikwillems
Copy link
Contributor Author

@ihor-sviziev
It basically does the same thing as the other implementations. It works on raw queries but does not join between quote and sales. Also it works in batches to precent memory limits.

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Nov 7, 2018

Hi @rikwillems,
Your first commit 8b57147 has different commiter email, as result - CLA showing that you didn't signed. Could you add that email to your github account OR just squash all your changes into single commit and force-push it?

@rikwillems
Copy link
Contributor Author

I added PR #19098

@ihor-sviziev
Copy link
Contributor

@rikwillems thank you!
I'll close this PR as it is duplicates #19098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants