Skip to content

2.2.6 Use batches and direct queries to fix sales address upgrade #19114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

2.2.6 Use batches and direct queries to fix sales address upgrade #19114

wants to merge 1 commit into from

Conversation

rikwillems
Copy link
Contributor

Description (*)

Magento Commerce compatible fix for sales address upgrade script.
New try to confirm to CLA.

Fixed Issues (if relevant)

  1. [update] enhance performance on large catalog #16570: enhance performance on large catalog
    (comment)
  2. 2.2.6 Use batches and direct queries to fix sales address upgrade #18945
  3. 2.2.6 Use batches and direct queries to fix sales address upgrade #19098

@magento-engcom-team
Copy link
Contributor

Hi @rikwillems. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rikwillems rikwillems changed the title Redo changed for CLA 2.2.6 Use batches and direct queries to fix sales address upgrade Nov 8, 2018
@rikwillems
Copy link
Contributor Author

@ ihor-sviziev the CLA shows it's signed now.
You comment regarding using the from column is fixed in this PR too.

@orlangur orlangur self-assigned this Nov 8, 2018
@orlangur
Copy link
Contributor

orlangur commented Nov 8, 2018

@rikwillems there is no need to create new pull requests, you can force push this - corrected branch - into previously used, like #18945.

Nowadays all changes must be applied to 2.3-develop first (see https://devdocs.magento.com/guides/v2.3/contributor-guide/contributing.html#rules).

@orlangur orlangur closed this Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants