Skip to content

#222249 configurable product images wrong sorting fix #22287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2019
Merged

#222249 configurable product images wrong sorting fix #22287

merged 1 commit into from
May 1, 2019

Conversation

Wirson
Copy link
Contributor

@Wirson Wirson commented Apr 11, 2019 •
edited by sdzhepa
Loading

Configurable Product Gallery Images Out of Order when More than 10 images. Images sort order does not comply with that in admin panel for configurable product.

Description (*)

'position' argument was provided as string, thus result of sorting was like: 1, 10, 11, 2, 3, 4, ... .

Fixed Issues (if relevant)

  1. Configurable Product Gallery Images Out of Order when More than 10 images #22249: Configurable Product Gallery Images Out of Order when More than 10 images

Manual testing scenarios (*)

  1. Exact steps to reproduce are extensively provided in related issue

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2019

Hi @Wirson. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 11, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ghost ghost assigned orlangur Apr 11, 2019
@soleksii soleksii self-assigned this Apr 15, 2019
sivaschenko
sivaschenko requested changes Apr 15, 2019
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Wirson , thanks for the pull request! Can you please fix the commit authorship in this pull request ( see comment #22287 (comment) )

@ghost ghost assigned sivaschenko Apr 15, 2019
@Wirson Wirson mentioned this pull request Apr 15, 2019
Merged
4 tasks
orlangur
orlangur reviewed Apr 15, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash changes into a single commit so that we have perfectly clean history 😉

orlangur
orlangur requested changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash changes into a single commit so that we have perfectly clean history 😉

@Wirson Wirson force-pushed the 22249-configurable-product-imgs-wrong-order branch from 59517f4 to e6b61ef Compare April 15, 2019 14:27
@Wirson Wirson force-pushed the 22249-configurable-product-imgs-wrong-order branch from e6b61ef to 700a153 Compare April 15, 2019 14:48
@ghost ghost assigned sidolov Apr 29, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4844 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@Wirson thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@Nazar65 Nazar65 self-assigned this Apr 30, 2019
@soleksii
Copy link

✔️ QA Passed

@magento-engcom-team magento-engcom-team mentioned this pull request May 1, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 700a153 into magento:2.3-develop May 1, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 1, 2019

Hi @Wirson, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request May 1, 2019
@sidolov
ENGCOM-4844: #222249 configurable product images wrong sorting fix #2…
49097a9 
…2287
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 1, 2019
@amol2jcommerce amol2jcommerce mentioned this pull request May 2, 2019
Closed
4 tasks
@ihor-sviziev ihor-sviziev mentioned this pull request Mar 22, 2023
Merged
6 tasks
This was referenced Mar 23, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur requested changes

@sivaschenko sivaschenko sivaschenko requested changes

@sidolov sidolov sidolov approved these changes

Assignees

@orlangur orlangur

@sivaschenko sivaschenko

@Nazar65 Nazar65

@sidolov sidolov

@soleksii soleksii

Labels
Area: Frontend Award: bug fix Component: Swatches Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.
8 participants
@Wirson @magento-cicd2 @magento-engcom-team @soleksii @orlangur @sivaschenko @sidolov @Nazar65