-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix image order when 10+ images on dropdown configurable products #37282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image order when 10+ images on dropdown configurable products #37282
Conversation
Hi @lumnn. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento create issue |
@magento create issue |
@magento run Functional Tests B2B ,Functional Tests CE,Functional Tests EE ,Unit Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
It seems that bot moved it to Ready for Testing hence pulling it back to Extended testing. Thank you! |
@magento run Functional Tests CE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
@magento run Functional Tests EE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
As all tests are passed, moving it to Merge in Progress now. Thank you! |
Description (*)
This PR fixes an images order, which was described mostly in this issue #22249 and fixed in this commit 700a153
The same issue appears for products using the Dropdown attribute types (not swatches)
Related Pull Requests
Manual testing scenarios (*)
WJ12-XS-Blue
productQuestions or comments
Does it need new issue?
Contribution checklist (*)
Resolved issues: