Skip to content

Fixed Issue #22087 #22646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2019
Merged

Fixed Issue #22087 #22646

merged 2 commits into from
Jun 7, 2019

Conversation

surabhisrivastava09
Copy link
Member

Fixed Issue #22087

Description (*)

Products Ordered Report - Not grouped by product

Manual testing scenarios (*)

  1. In the Magento 2 admin go to Reports -> Products -> Ordered
  2. Select a date range where you know you have sold products spanning across multiple orders
  3. Select 'Show By' year
  4. Hit refresh

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Fixed Issue #22087
@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @Surabhi-Cedcoss. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram, thank you for the review.
ENGCOM-5052 has been created to process this Pull Request

@soleksii soleksii self-assigned this May 6, 2019
@Nazar65 Nazar65 self-assigned this May 6, 2019
@soleksii
Copy link

soleksii commented May 6, 2019

✔️ QA Passed

Before:

before

After:

after

Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Surabhi-Cedcoss , thanks for the pull request!

Sorry, this changes request was created by mistake.

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-5052 has been created to process this Pull Request

@nicholasscottfish
Copy link

Hi @sivaschenko, is this PR still under review. The original issue relates to this PR #22806, what is the reason for the build fail do you know?

@sivaschenko
Copy link
Member

Hi @nicholasscottfish The status of the PR can be viewed in the right sidebar under the labels section. It is in progress of delivering to mainline. Please ignore Travis build fail - Travis tests are not used anymore.

magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request Jun 7, 2019
@magento-engcom-team magento-engcom-team merged commit 82d09dc into magento:2.3-develop Jun 7, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 7, 2019

Hi @Surabhi-Cedcoss, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jun 7, 2019
krishprakash pushed a commit to krishprakash/magento2 that referenced this pull request Jun 14, 2019
@krishprakash krishprakash mentioned this pull request Jun 14, 2019
4 tasks
krishprakash pushed a commit to krishprakash/magento2 that referenced this pull request Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants