Skip to content

Fixes magento#22087, products sold report grouped by product with total quantity #22806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixes magento#22087, products sold report grouped by product with total quantity #22806

wants to merge 2 commits into from

Conversation

nicholasscottfish
Copy link

@nicholasscottfish nicholasscottfish commented May 9, 2019 •
edited
Loading

Summary

 - Fixes bug with products sold report to group by product and show total quantity
 - Fixes issue #22087

Description

Fixes an issue with Products Ordered report where they are not grouped by product. This PR fixes this issue by grouping the report results by product and providing a total quantity.

Fixed Issues

  1. Products Ordered Report - Not grouped by product #22087: Products Ordered Report - Not grouped by product

Manual testing scenarios (*)

Preconditions (*)

  1. Magento 2.2.3

Steps to reproduce (*)

  1. In the Magento 2 admin go to Reports -> Products -> Ordered
  2. Select a date range where you know you have sold products spanning across multiple orders
  3. Select 'Show By' year
  4. Hit refresh

Expected result (*)

  1. I would expect to see a list of products sold per year, grouped by product with a total quantity

Actual result (*)

  1. I see a list of products sold per year, with multiple entries for a single product on a per order basis

nicholasscottfish added 2 commits May 9, 2019 10:59
Fixes #22087, products sold report grouped by product with total quan…
2acc97f 
…tity

Reference #22087:

Fixes report to produce a list of products sold per year, grouped by product with a total quantity.

### Preconditions (*)
1. Magento 2.2.3

### Steps to reproduce (*)
1. In the Magento 2 admin go to Reports -> Products -> Ordered
2. Select a date range where you know you have sold products spanning across multiple orders
3. Select 'Show By' year
4. Hit refresh

### Expected result (*)
1. I would expect to see a list of products sold per year, grouped by product with a total quantity

### Actual result (*)
1. I see a list of products sold per year, with multiple entries for a single product on a per order basis
Merge pull request #1 from nicholasscottfish/bugfix/22087-product-sol…
9494f3b 
…d-report-nicholasscottfish

Fixes #22087, products sold report grouped by product with tot…
@m2-assistant
Copy link

m2-assistant bot commented May 9, 2019

Hi @nicholasscottfish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 9, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@miguelbalparda miguelbalparda self-assigned this May 9, 2019
@nicholasscottfish
Copy link
Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @nicholasscottfish. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @nicholasscottfish, here is your new Magento instance.
Admin access: https://pr-22806.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-5101 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@nicholasscottfish thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@nicholasscottfish
Copy link
Author

nicholasscottfish commented May 11, 2019 •
edited
Loading

Hi there, thanks for the extended permissions, that is greatly appreciated. Please may you provide me with an update on this pull request, I see the PR has been approved but the travis build has failed although I can’t quite make out what on. Is it okay to be merged in or is further work required?

Kind regards

@soleksii soleksii self-assigned this May 13, 2019
@Nazar65 Nazar65 self-assigned this May 13, 2019
@sivaschenko
Copy link
Member

Hi @nicholasscottfish , thanks for the pull request! However, this issue was fixed earlier in #22646

I have to close this pull request as duplicate, but let's collaborate on delivering the earlier pull request with best quality.

@m2-assistant
Copy link

m2-assistant bot commented May 20, 2019

Hi @nicholasscottfish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@nicholasscottfish nicholasscottfish mentioned this pull request Jun 3, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelbalparda miguelbalparda miguelbalparda approved these changes

Assignees

@Nazar65 Nazar65

@miguelbalparda miguelbalparda

@soleksii soleksii

Labels
Component: Reports duplicate Progress: testing in progress Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nicholasscottfish @magento-cicd2 @magento-engcom-team @sivaschenko @miguelbalparda @Nazar65 @soleksii