Skip to content

Fixed issue #22640 #22649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed issue #22640 #22649

wants to merge 1 commit into from

Conversation

surabhisrivastava09
Copy link
Member

Fixed issue #22640

Description (*)

Add tax rule form checkbox design is not as per the magento admin panel checkbox design, It is showing default design

Manual testing scenarios (*)

  1. Go to Tax rules in Admin panel.
  2. Open Add New Tax Rule Form and click Add New Tax Rate Button.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Fixed issue #22640
@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @Surabhi-Cedcoss. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@surabhisrivastava09
Copy link
Member Author

Change done in wrong file

@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @Surabhi-Cedcoss, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants