Skip to content

Add tax rule form checkbox design is not as per the magento admin panel checkbox design, It is showing default design #22640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
surabhisrivastava09 opened this issue May 4, 2019 · 18 comments
Closed

Add tax rule form checkbox design is not as per the magento admin panel checkbox design, It is showing default design #22640

surabhisrivastava09 opened this issue May 4, 2019 · 18 comments
Assignees
@surabhisrivastava09 @mahesh-rajawat
Labels
Component: Admin Component: Ui Event: dmcdindia1 Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@surabhisrivastava09
Copy link
Member

surabhisrivastava09 commented May 4, 2019 •
edited
Loading

Preconditions (*)

  1. Magento 2.3.1

Steps to reproduce (*)

  1. Go to Tax rules in Admin panel.
  2. Open Add New Tax Rule Form and click Add New Tax Rate Button.

Expected result (*)

Screenshot_2019-05-04_11-30-16

Actual result (*)

Screenshot_2019-05-04_11-29-57
@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @Surabhi-Cedcoss. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Surabhi-Cedcoss do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 4, 2019
@shikhamis11 shikhamis11 self-assigned this May 4, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@shikhamis11
Copy link
Member

shikhamis11 commented May 4, 2019 •
edited
Loading

#dmcdindia1

@shikhamis11
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, here is your Magento instance.
Admin access: https://i-22640-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@surabhisrivastava09 surabhisrivastava09 self-assigned this May 4, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @Surabhi-Cedcoss. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.
    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

@shikhamis11
Copy link
Member

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, here is your Magento instance.
Admin access: https://i-22640-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@shikhamis11 shikhamis11 added Component: Admin Component: Ui Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels May 4, 2019
@ghost ghost unassigned shikhamis11 May 4, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99550, MAGETWO-99551 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 4, 2019
@ghost
Copy link

ghost commented May 4, 2019

@magento-engcom-team give me 2.3-develop instance #dmcdindia1

@magento-engcom-team
Copy link
Contributor

@ManishGangola-Webkul thank you for joining. Please accept team invitation here and self-assign the issue.

@magento-engcom-team
Copy link
Contributor

Hi @ManishGangola-Webkul. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ManishGangola-Webkul, here is your Magento instance.
Admin access: https://i-22640-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@surabhisrivastava09
Copy link
Member Author

surabhisrivastava09 commented May 4, 2019 •
edited
Loading

I am working on this at #dmcdindia1

@ghost ghost self-assigned this May 4, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @ManishGangola-Webkul. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@surabhisrivastava09 surabhisrivastava09 changed the title Add tax rule form checbox design is not as per the magento admin panel checbox design, It is showing default design Add tax rule form checkbox design is not as per the magento admin panel checbox design, It is showing default design May 4, 2019
@surabhisrivastava09 surabhisrivastava09 changed the title Add tax rule form checkbox design is not as per the magento admin panel checbox design, It is showing default design Add tax rule form checkbox design is not as per the magento admin panel checkbox design, It is showing default design May 4, 2019
@surabhisrivastava09 surabhisrivastava09 mentioned this issue May 4, 2019
Closed
4 tasks
@ghost ghost unassigned surabhisrivastava09 May 4, 2019
@surabhisrivastava09 surabhisrivastava09 mentioned this issue May 4, 2019
Merged
4 tasks
@ghost ghost assigned surabhisrivastava09 and unassigned ghost May 4, 2019
magento-engcom-team added a commit to okorshenko/magento2 that referenced this issue May 14, 2019
@magento-engcom-team
ENGCOM-5061: Fixed Issue magento#22640 magento#22655
9b81072 
 - Merge Pull Request magento#22655 from Surabhi-Cedcoss/magento2:magento2.3.1-pr3
 - Merged commits:
   1. ef02f2e
   2. 8223bf1
   3. 0a21f26
   4. 7e394aa
magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this issue May 14, 2019
@sidolov
ENGCOM-5061: Fixed Issue magento#22640 magento#22655
b265f9e
mahesh-rajawat pushed a commit to mahesh-rajawat/magento2 that referenced this issue May 15, 2019
@mahesh-rajawat
Fixed issue magento#22640
e5b5bc1 
Fixed issue magento#22640
mahesh-rajawat pushed a commit to mahesh-rajawat/magento2 that referenced this issue May 15, 2019
@mahesh-rajawat
Fixed issue magento#22640
ae9fa79 
Fixed issue magento#22640
@mahesh-rajawat mahesh-rajawat mentioned this issue May 15, 2019
Merged
4 tasks
@ghost ghost assigned mahesh-rajawat May 15, 2019
@magento-engcom-team
Copy link
Contributor

Hi @Surabhi-Cedcoss. Thank you for your report.
The issue has been fixed in #22908 by @maheshWebkul721 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.10 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label May 20, 2019
magento-engcom-team added a commit that referenced this issue May 20, 2019
@magento-engcom-team
ENGCOM-5128: [Backport] Fixed Issue #22640 #22908
327c55c 
 - Merge Pull Request #22908 from maheshWebkul721/magento2:2.2-develop-PR-port-22655
 - Merged commits:
   1. e5b5bc1
   2. ae9fa79
   3. a2fc106
   4. 6fc7d7a
magento-engcom-team pushed a commit that referenced this issue May 20, 2019
@VladimirZaets
ENGCOM-5128: [Backport] Fixed Issue #22640 #22908
7456924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@surabhisrivastava09 surabhisrivastava09

@mahesh-rajawat mahesh-rajawat

Labels
Component: Admin Component: Ui Event: dmcdindia1 Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shikhamis11 @surabhisrivastava09 @magento-engcom-team @mahesh-rajawat