Skip to content

Fixed Issue #22640 #22655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 14, 2019
Merged

Fixed Issue #22640 #22655

merged 4 commits into from
May 14, 2019

Conversation

surabhisrivastava09
Copy link
Member

@surabhisrivastava09 surabhisrivastava09 commented May 4, 2019 •
edited
Loading

Fixed Issue #22640

Description (*)

Add tax rule form checkbox design is not as per the magento admin panel checkbox design, It is showing default design

Manual testing scenarios (*)

  1. Go to Tax rules in Admin panel.
  2. Open Add New Tax Rule Form and click Add New Tax Rate Button.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Surabhi Srivastava added 2 commits May 4, 2019 06:16
Fixed issue #22640
ef02f2e 
Fixed issue #22640
Fixed issue #22640
8223bf1 
Fixed issue #22640
@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @Surabhi-Cedcoss. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@surabhisrivastava09 surabhisrivastava09 changed the title Magento2.3.1 pr3 Fixed Issue May 4, 2019
Changes done in wrong file so i am reverting my chnages
0a21f26 
Changes done in wrong file so i am reverting my chnages
@surabhisrivastava09 surabhisrivastava09 changed the title Fixed Issue Fixed Issue #22640 May 4, 2019
@rogyar
Copy link
Contributor

rogyar commented May 5, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@rogyar rogyar self-assigned this May 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-22655.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-5061 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this May 7, 2019
@Nazar65 Nazar65 self-assigned this May 7, 2019
@VasylShvorak
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @VasylShvorak. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @VasylShvorak, here is your Magento instance.
Admin access: https://i-22655-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@ghost ghost added the Progress: accept label May 7, 2019
magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request May 14, 2019
@sidolov
ENGCOM-5061: Fixed Issue magento#22640 magento#22655
b265f9e
@magento-engcom-team magento-engcom-team merged commit 7e394aa into magento:2.3-develop May 14, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 14, 2019

Hi @Surabhi-Cedcoss, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 14, 2019
mahesh-rajawat pushed a commit to mahesh-rajawat/magento2 that referenced this pull request May 15, 2019
@Nazar65 @mahesh-rajawat
magento#22655 static-test-fix
6fc7d7a
@mahesh-rajawat mahesh-rajawat mentioned this pull request May 15, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@Nazar65 Nazar65

@VasylShvorak VasylShvorak

Labels
Area: Frontend Community Insider: Cedcommerce community-insider-contribution Component: Tax Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@surabhisrivastava09 @rogyar @magento-engcom-team @VasylShvorak @Nazar65