Skip to content

#22869 - defaulting customer storeId fix #22893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Wirson
Copy link
Contributor

@Wirson Wirson commented May 14, 2019

Description (*)

Fix prevent saving default customer storeId if one was not passed in rest request. StoreId is taken from previously loaded customer data if none is provided.

Fixed Issues (if relevant)

  1. REST: Updating a customer without store_id sets the store_id to default  #22869: REST: Updating a customer without store_id sets the store_id to default

Manual testing scenarios (*)

  1. use steps provided in issue description

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 14, 2019

Hi @Wirson. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Wirson. Thanks for collaboration. Please fix the integration tests.

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5116 has been created to process this Pull Request

@Wirson
Copy link
Contributor Author

Wirson commented May 17, 2019

Hi @Wirson. Thanks for collaboration. Please fix the integration tests.

No tests failed, several were skipped.

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5116 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

Before:

before

After:

after

@Nazar65 Nazar65 force-pushed the 22869-rest-customer-update-store-id-fix branch from 3a1feb1 to 7caa429 Compare May 20, 2019 11:04
@Nazar65 Nazar65 force-pushed the 22869-rest-customer-update-store-id-fix branch from 7caa429 to a07e6d5 Compare May 20, 2019 13:05
@Nazar65 Nazar65 force-pushed the 22869-rest-customer-update-store-id-fix branch from a07e6d5 to 0775cc0 Compare May 20, 2019 13:06
@Nazar65 Nazar65 force-pushed the 22869-rest-customer-update-store-id-fix branch from 0775cc0 to c4996a8 Compare May 20, 2019 14:07
@Nazar65 Nazar65 force-pushed the 22869-rest-customer-update-store-id-fix branch from c4996a8 to f5bf174 Compare May 21, 2019 06:16
magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request May 24, 2019
@magento-engcom-team magento-engcom-team merged commit f5bf174 into magento:2.3-develop May 24, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 24, 2019

Hi @Wirson, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 24, 2019
Nazar65 added a commit to Wirson/magento2 that referenced this pull request May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants