Skip to content

[Backport] #22869 - defaulting customer storeId fix #22895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Wirson
Copy link
Contributor

@Wirson Wirson commented May 14, 2019

Description (*)

Backport pull request
Fix prevent saving default customer storeId if one was not passed in rest request. StoreId is taken from previously loaded customer data if none is provided.

Fixed Issues (if relevant)

  1. REST: Updating a customer without store_id sets the store_id to default  #22869: REST: Updating a customer without store_id sets the store_id to default

Manual testing scenarios (*)

  1. use steps provided in issue description

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Backport for: #22893

@m2-assistant
Copy link

m2-assistant bot commented May 14, 2019

Hi @Wirson. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov sidolov changed the title #22869 - defaulting customer storeId fix - backport [Backport] #22869 - defaulting customer storeId fix May 22, 2019
@dmytro-ch dmytro-ch self-assigned this May 27, 2019
@dmytro-ch dmytro-ch self-requested a review May 27, 2019 12:28
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Wirson, could you please merge the latest changes from 2.2-develop into your working branch, and update it according to original PR.
Please, also fix the integration test if necessary.

Thank you!

@Wirson Wirson force-pushed the 22869-rest-customer-update-store-id-fix-2.2 branch from 116e8cb to 9fd7722 Compare May 29, 2019 09:07
@Wirson
Copy link
Contributor Author

Wirson commented May 29, 2019

Hi @Wirson, could you please merge the latest changes from 2.2-develop into your working branch, and update it according to original PR.
Please, also fix the integration test if necessary.

Thank you!

Code updated. I did not remove lines removed in original PR due to failing tests. Just a code style refactor.
Failing integration tests are only skipped, right now no tests really fail.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-5188 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented May 31, 2019

Hi @Wirson, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants