Skip to content

[Validator] Fix wrong behaviour of validation scroll #23035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Den4ik
Copy link
Contributor

@Den4ik Den4ik commented May 28, 2019

Description (*)

If page have validating elements page scrolling down and up instead of focusing on non valid element

Fixed Issues (if relevant)

  1. Wrong behaviour of validation scroll #23034: Wrong behaviour of validation scroll

Manual testing scenarios (*)

  1. Open create order page in admin panel
  2. Click Add Product button
  3. Click Submit Order button

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 28, 2019

Hi @Den4ik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5176 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

Before:

before

After:

after

@m2-assistant
Copy link

m2-assistant bot commented May 31, 2019

Hi @Den4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ihor-sviziev
Copy link
Contributor

@Den4ik FYI this PR did regression on iPhone X, more info #26327

@Den4ik
Copy link
Contributor Author

Den4ik commented Jan 9, 2020

@ihor-sviziev thanks for reference

arendarenko added a commit to arendarenko/magento2 that referenced this pull request Feb 7, 2020
add fix for scrolling on iPhone before magento#23035 was merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants