-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix the wrong behavior of validation scroll on the iPhone X #26327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the wrong behavior of validation scroll on the iPhone X #26327
Conversation
Hi @iGerchak. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
I believe this can't be covered with any test |
@magento give me test instance |
Hi @ihor-sviziev. Thank you for your request. I'm working on Magento instance for you |
@magento give me 2.4-develop instance |
Hi @ihor-sviziev, here is your new Magento instance. |
Hi @ihor-sviziev. Thank you for your request. I'm working on Magento 2.4-develop instance for you |
Hi @ihor-sviziev, here is your Magento instance. |
@magento give me test instance |
Hi @ihor-sviziev. Thank you for your request. I'm working on Magento instance for you |
Hi @ihor-sviziev, here is your new Magento instance. |
Hi @ihor-sviziev, thank you for the review. |
Hi @ptylek, thank you for the review. |
✔️ QA passed |
Hi @iGerchak, thank you for your contribution! |
Description (*)
Changes from PR: #23035 added regression for validation scroll.
On the iPhone X, if try to run validation programmatically (without tap to screen), Magento doesn't scroll to the failed field.
This pull request fixes this issue.
Preconditions
Manual testing scenarios
Expected result
Actual result
Contribution checklist (*)