#23053 : sendfriend verifies product visibility instead of status

[Wirson]

Description (*)

Sendfriend feature was verifying product status only. This could cause sending a link for enabled product invisible in catalog and/or search.

Fixed Issues (if relevant)

1. Sendfriend works for products with visibility not visible individually #23053: Sendfriend works for products with visibility not visible individually

Manual testing scenarios (*)

Follow steps provided in #23053

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Wirson. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-cicd2]

All committers have signed the CLA.

[orlangur]

@Wirson please enforce this case with integration test and sign CLA.

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

[Wirson]

@orlangur I added related test case, please review.
Static test returns error:

FILE: /var/www/html/app/code/Magento/SendFriend/Controller/Product.php

---

FOUND 1 ERROR AFFECTING 1 LINE

64 | ERROR | [x] There must be exactly one blank line between lines

PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY

But I do not really get the point

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-5228 has been created to process this Pull Request

[soleksii]

✔️ QA Passed

Before:

After:

[m2-assistant]

Hi @Wirson, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.