Skip to content

[Backport] #23053 : sendfriend verifies product visibility instead of status #23189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

speedy008
Copy link
Contributor

Original Pull Request

#23118

Description (*)

Sendfriend feature was verifying product status only. This could cause sending a link for enabled product invisible in catalog and/or search.

Fixed Issues (if relevant)

  1. Sendfriend works for products with visibility not visible individually #23053: Sendfriend works for products with visibility not visible individually

Manual testing scenarios (*)

Follow steps provided in #23053

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 10, 2019

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@speedy008 , please, take a look at the failed unit tests

@ghost ghost assigned sidolov Jun 19, 2019
@sidolov sidolov added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 19, 2019
@sidolov
Copy link
Contributor

sidolov commented Jul 5, 2019

@speedy008 , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Jul 5, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 5, 2019

Hi @speedy008, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants