Skip to content

Make align edit and remove icon in the minicart. #26654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chirag-wagento
Copy link
Contributor

@chirag-wagento chirag-wagento commented Feb 2, 2020

Description (*)

In the minicart edit and remove icon is not aligned.

Fixed Issues (if relevant)

  1. In the minicart edit and remove icon is not aligned. #26652: In the minicart edit and remove icon is not aligned.

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 2, 2020

Hi @chirag-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Feb 2, 2020
@lenaorobei lenaorobei added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup labels Mar 9, 2020
lenaorobei
lenaorobei previously approved these changes Mar 9, 2020
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures are not related to the changes in this PR.

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-7070 has been created to process this Pull Request

Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chirag-wagento.

Looks like edit and remove icons still don't seem to be aligned properly (on luma and blank themes)

Actual Result:
after

@chirag-wagento Could you take a look?

Thanks!

@ghost ghost dismissed lenaorobei’s stale review March 10, 2020 11:00

Pull Request state was updated. Re-review required.

@lenaorobei
Copy link
Contributor

Closing this PR due to inactivity. Please feel free to reopen if you are going to continue working on it.
Thank you.

@lenaorobei lenaorobei closed this Mar 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 24, 2020

Hi @chirag-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Event: mm20in Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants