Skip to content

Align minicart edit and remove icons #27037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

brandonsabino
Copy link

@brandonsabino brandonsabino commented Feb 26, 2020

Description (*)

Adjusted the margin for minicart edit and remove icons so they may align properly with the quantity info box.

  1. In the minicart edit and remove icon is not aligned. In the minicart edit and remove icon is not aligned. #26652

Manual testing scenarios (*)

  1. Deploy sample data or create a product in the admin panel.
  2. Add a product to the cart.
  3. Click on the mini-cart icon.
  4. View margins and position with browser developer tools.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 26, 2020

Hi @brandonsabino. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@brandonsabino brandonsabino changed the title Align minicart edit and remove icons #26652 Align minicart edit and remove icons Feb 26, 2020
@brandonsabino
Copy link
Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @brandonsabino. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @brandonsabino, here is your new Magento instance.
Admin access: https://pr-27037.instances.magento-community.engineering/admin_f84d
Login: 94a0e024 Password: 43072cfedc9a
Instance will be terminated in up to 3 hours.

@brandonsabino
Copy link
Author

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @brandonsabino. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @brandonsabino, here is your Magento instance.
Admin access: https://i-27037-2-4-develop.instances.magento-community.engineering/admin_ef6e
Login: a040e16c Password: 29cd1aa34d4a
Instance will be terminated in up to 3 hours.

@brandonsabino
Copy link
Author

@magento I was able to reproduce the changes successfully in each test environment.

@m2-assistant
Copy link

m2-assistant bot commented Feb 28, 2020

Hi @brandonsabino, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-assistant
Copy link

m2-assistant bot commented Feb 28, 2020

Hi @brandonsabino, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@brandonsabino brandonsabino reopened this Feb 28, 2020
@lenaorobei
Copy link
Contributor

This PR fixes the same issue as #26654.

Closing this one, because #26654 was opened earlier and the issue is assigned to @chirag-wagento.

@lenaorobei lenaorobei closed this Mar 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 9, 2020

Hi @brandonsabino, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants