Skip to content

#1796: [MFTF] Unskip AdminMediaGalleryUploadCategoryImageTest #29875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 7, 2020
Merged

#1796: [MFTF] Unskip AdminMediaGalleryUploadCategoryImageTest #29875

merged 7 commits into from
Sep 7, 2020

Conversation

joweecaquicla
Copy link

Description (*)

Unskipped AdminMediaGalleryUploadCategoryImageTest and will run MFTF builds to check and confirm that the test is stable.

Related Pull Requests

N/A

Fixed Issues (if relevant)

  1. Fixes [MFTF] Unskip AdminMediaGalleryUploadCategoryImageTest adobe-stock-integration#1796

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 2, 2020

Hi @joweecaquicla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

@joweecaquicla joweecaquicla changed the title #1796: [MFTF] Unskip AdminMediaGalleryUploadCategoryImageTest [WIP] #1796: [MFTF] Unskip AdminMediaGalleryUploadCategoryImageTest Sep 2, 2020
magento/adobe-stock-integration#1796: [MFTF] Unskip AdminMediaGallery…
6387cbc 
…UploadCategoryImageTest - modified test and action group
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

@rogyar rogyar self-assigned this Sep 3, 2020
rogyar
rogyar reviewed Sep 3, 2020
View reviewed changes
app/code/Magento/MediaGalleryUi/Test/Mftf/Test/AdminMediaGalleryUploadCategoryImageTest.xml
@@ -40,6 +37,7 @@
<actionGroup ref="AdminSaveCategoryFormActionGroup" stepKey="saveCategoryForm"/>
<actionGroup ref="AdminOpenMediaGalleryFromCategoryImageUploaderActionGroup" stepKey="openMediaGalleryFromImageUploader"/>
<actionGroup ref="ResetAdminDataGridToDefaultViewActionGroup" stepKey="resetAdminDataGridToDefaultView"/>
<waitForLoadingMaskToDisappear stepKey="waitForLoadingMaskToDisappear"/>
<actionGroup ref="AdminMediaGalleryAssertImageInGridActionGroup" stepKey="assertImageInGrid">
Copy link
Contributor

@rogyar rogyar Sep 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor recommendation. If you take a look at AdminEnhancedMediaGalleryImageActionsSection.imageInGrid element selector, you will find that it might be too complex and cause fluky tests in the result. If we could make the selector simpler somehow (or introduce a new one). Like asserting the title of the element with class="preview-image" or so. This change may stabilize such tests as this one.

Hope it will help.

magento/adobe-stock-integration#1796: [MFTF] Unskip AdminMediaGallery…
9bd9ea2 
…UploadCategoryImageTest - reverted previous changes, modified selector in section
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

1 similar comment
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

magento/adobe-stock-integration#1796: [MFTF] Unskip AdminMediaGallery…
3cafef5 
…UploadCategoryImageTest - used clear filters instead of reset view
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

joweecaquicla added 2 commits September 4, 2020 18:46
Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-17…
1cfdfb6 
…96-mftf-unskip-admin-media-gallery-upload-category-image-test
magento/adobe-stock-integration#1796: [MFTF] Unskip AdminMediaGallery…
4ccd690 
…UploadCategoryImageTest - added reset to default view after clearing filters
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

magento/adobe-stock-integration#1796: [MFTF] Unskip AdminMediaGallery…
34d1c12 
…UploadCategoryImageTest - added action to open catalog/category folder
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

@joweecaquicla joweecaquicla changed the title [WIP] #1796: [MFTF] Unskip AdminMediaGalleryUploadCategoryImageTest #1796: [MFTF] Unskip AdminMediaGalleryUploadCategoryImageTest Sep 4, 2020
@ghost ghost assigned sivaschenko Sep 4, 2020
@sivaschenko sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Sep 4, 2020
magento-engcom-team pushed a commit that referenced this pull request Sep 7, 2020
@sidolov
ENGCOM-8137: #1796: [MFTF] Unskip AdminMediaGalleryUploadCategoryImag…
7ecb857 
…eTest #29875
@magento-engcom-team magento-engcom-team merged commit 93947f1 into magento:2.4-develop Sep 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 7, 2020

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar left review comments

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

@rogyar rogyar

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGalleryUi Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: ASI Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MFTF] Unskip AdminMediaGalleryUploadCategoryImageTest
4 participants
@joweecaquicla @sivaschenko @rogyar @magento-engcom-team