Skip to content

#1796: [MFTF] Unskip AdminMediaGalleryUploadCategoryImageTest #29875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 7, 2020
Merged

#1796: [MFTF] Unskip AdminMediaGalleryUploadCategoryImageTest #29875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
197abeb
magento/adobe-stock-integration#1796: [MFTF] Unskip AdminMediaGallery…
Sep 2, 2020
6387cbc
magento/adobe-stock-integration#1796: [MFTF] Unskip AdminMediaGallery…
Sep 2, 2020
9bd9ea2
magento/adobe-stock-integration#1796: [MFTF] Unskip AdminMediaGallery…
Sep 3, 2020
3cafef5
magento/adobe-stock-integration#1796: [MFTF] Unskip AdminMediaGallery…
Sep 3, 2020
1cfdfb6
Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-17…
Sep 4, 2020
4ccd690
magento/adobe-stock-integration#1796: [MFTF] Unskip AdminMediaGallery…
Sep 4, 2020
34d1c12
magento/adobe-stock-integration#1796: [MFTF] Unskip AdminMediaGallery…
Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...to/MediaGalleryUi/Test/Mftf/ActionGroup/AdminMediaGalleryAssertImageInGridActionGroup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,5 @@
<argument name="title"/>
</arguments>
<waitForElementVisible selector="{{AdminEnhancedMediaGalleryImageActionsSection.imageInGrid(title)}}" stepKey="waitForImageToBeVisible"/>

</actionGroup>
</actionGroups>
2 changes: 1 addition & 1 deletion ...eryUi/Test/Mftf/ActionGroup/AdminOpenMediaGalleryFromCategoryImageUploaderActionGroup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
<conditionalClick stepKey="clickExpandContent" selector="{{AdminCategoryContentSection.sectionHeader}}" dependentSelector="{{AdminCategoryContentSection.selectFromGalleryButton}}" visible="false" />
<waitForElementVisible selector="{{AdminCategoryContentSection.selectFromGalleryButton}}" stepKey="waitForSelectFromGallery" />
<click selector="{{AdminCategoryContentSection.selectFromGalleryButton}}" stepKey="clickSelectFromGallery" />
<waitForPageLoad stepKey="waitForPageLoad" />
<waitForPageLoad stepKey="waitForPageLoad"/>
</actionGroup>
</actionGroups>
13 changes: 8 additions & 5 deletions app/code/Magento/MediaGalleryUi/Test/Mftf/Test/AdminMediaGalleryUploadCategoryImageTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
<test name="AdminMediaGalleryUploadCategoryImageTest">
<annotations>
<skip>
<issueId value="https://github.com/magento/adobe-stock-integration/issues/1796"/>
</skip>
<features value="AdminMediaGalleryImagePanel"/>
<useCaseId value="https://github.com/magento/adobe-stock-integration/issues/1435"/>
<stories value="User uploads image outside of the Media Gallery"/>
Expand Down Expand Up @@ -39,9 +36,15 @@
<actionGroup ref="AddCategoryImageActionGroup" stepKey="addCategoryImage"/>
<actionGroup ref="AdminSaveCategoryFormActionGroup" stepKey="saveCategoryForm"/>
<actionGroup ref="AdminOpenMediaGalleryFromCategoryImageUploaderActionGroup" stepKey="openMediaGalleryFromImageUploader"/>
<actionGroup ref="ResetAdminDataGridToDefaultViewActionGroup" stepKey="resetAdminDataGridToDefaultView"/>
<actionGroup ref="ClearFiltersAdminDataGridActionGroup" stepKey="clearFilter"/>
<actionGroup ref="AdminMediaGalleryFolderSelectActionGroup" stepKey="selectCatalogFolder">
<argument name="name" value="catalog"/>
</actionGroup>
<actionGroup ref="AdminMediaGalleryFolderSelectActionGroup" stepKey="selectCategoryFolder">
<argument name="name" value="category"/>
</actionGroup>
<actionGroup ref="AdminMediaGalleryAssertImageInGridActionGroup" stepKey="assertImageInGrid">
Copy link
Contributor

@rogyar rogyar Sep 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor recommendation. If you take a look at AdminEnhancedMediaGalleryImageActionsSection.imageInGrid element selector, you will find that it might be too complex and cause fluky tests in the result. If we could make the selector simpler somehow (or introduce a new one). Like asserting the title of the element with class="preview-image" or so. This change may stabilize such tests as this one.

Hope it will help.

<argument name="title" value="ProductImage.filename"/>
<argument name="title" value="ProductImage.fileName"/>
</actionGroup>
</test>
</tests>