Skip to content

Fixes to launch Magento with PHP 8.1 - part 1 #34637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 22, 2021
Merged

Fixes to launch Magento with PHP 8.1 - part 1 #34637

merged 4 commits into from
Nov 22, 2021

Conversation

karyna-t
Copy link
Contributor

@karyna-t karyna-t commented Nov 15, 2021 •
edited
Loading

Description (*)

Fixes for compatibility with PHP 8.1 (to be able to launch Magento)
Part 1

Related Pull Requests

Related Issues

  1. Add fixes Magento to run on PHP 8.1 #34505

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-github-services m2-github-services added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 15, 2021
@karyna-t karyna-t changed the title [WIP] Fix magento to launch with php8.1 - part 1 Fixes to launch Magento with PHP 8.1 - part 1 Nov 15, 2021
@andrewbess andrewbess added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: Platform Health labels Nov 15, 2021
@andrewbess andrewbess self-assigned this Nov 15, 2021
@xmav
Copy link
Contributor

xmav commented Nov 15, 2021

@mageto run Static Tests, Semantic Version Checker

2 similar comments
@karyna-t
Copy link
Contributor Author

@mageto run Static Tests, Semantic Version Checker

@andrewbess
Copy link
Contributor

@mageto run Static Tests, Semantic Version Checker

@andrewbess andrewbess mentioned this pull request Nov 17, 2021
Closed
5 tasks
ihor-sviziev
ihor-sviziev requested changes Nov 17, 2021
View reviewed changes
@karyna-t karyna-t force-pushed the fix-magento-to-launch-with-php8.1-part1 branch 2 times, most recently from cee3fb2 to 82c8c18 Compare November 17, 2021 15:46
@karyna-t karyna-t force-pushed the fix-magento-to-launch-with-php8.1-part1 branch from 82c8c18 to 1db34cc Compare November 18, 2021 09:50
andrewbess
andrewbess approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @karyna-tsymbal-atwix
Thank you for your work here.
Approved ✔️

@andrewbess
Copy link
Contributor

@magento run Static Tests with env PHP 8.1

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t
Copy link
Contributor Author

@magento run Static Tests

@karyna-t
Copy link
Contributor Author

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess
Copy link
Contributor

@magento run Static Tests, Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t karyna-t force-pushed the fix-magento-to-launch-with-php8.1-part1 branch from 96fc6d6 to bf17530 Compare November 19, 2021 14:05
@magento magento deleted a comment from xmav Nov 19, 2021
@karyna-t karyna-t force-pushed the fix-magento-to-launch-with-php8.1-part1 branch from bf17530 to 9f0f967 Compare November 22, 2021 14:09
@karyna-t
Copy link
Contributor Author

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t karyna-t force-pushed the fix-magento-to-launch-with-php8.1-part1 branch from 3934150 to 9f0f967 Compare November 22, 2021 15:44
@karyna-t
Copy link
Contributor Author

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t
Copy link
Contributor Author

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 268995f into magento:platform-health Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbess andrewbess andrewbess approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@fascinosum fascinosum Awaiting requested review from fascinosum

Assignees

@ihor-sviziev ihor-sviziev

@xmav xmav

@fascinosum fascinosum

@andrewbess andrewbess

Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: review Project: Platform Health
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@karyna-t @xmav @andrewbess @ihor-sviziev @fascinosum @magento-devops-reposync-svc @m2-github-services