Fixes to launch Magento with PHP 8.1 #34506

karyna-t · 2021-11-02T15:55:46Z

Description (*)

Fixes for compatibility with PHP 8.1 (to be able to launch Magento)

Related Pull Requests

Fixed Issues

Fixes Add fixes Magento to run on PHP 8.1 #34505

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-11-02T15:55:49Z

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

fascinosum · 2021-11-03T21:40:47Z

app/code/Magento/Analytics/Model/ReportXml/ModuleIterator.php

@@ -34,6 +34,7 @@ public function __construct(
     *
     * @return array
     */
+    #[\ReturnTypeWillChange]
    public function current()


I would recommend to specify a proper return type for this method instead

Hi @fascinosum , in PHP >= 8 the return type for this method is mixed (https://www.php.net/manual/en/class.iteratoriterator.php) , but in PHP 7.4 this return type is not specified yet.

fascinosum · 2021-11-03T21:41:13Z

app/code/Magento/Analytics/ReportXml/Query.php

@@ -82,6 +82,7 @@ public function getConfig()
     * @return mixed data which can be serialized by <b>json_encode</b>,
     * which is a value of any type other than a resource.
     */
+    #[\ReturnTypeWillChange]


I would recommend to specify a proper return type for this method instead

Hi @fascinosum , in PHP >= 8 the return type for this method is mixed (https://www.php.net/manual/en/jsonserializable.jsonserialize.php) , but in PHP 7.4 this return type is not specified yet.

fascinosum · 2021-11-03T21:45:21Z

app/code/Magento/Backend/App/DefaultPath.php

@@ -24,7 +24,7 @@ class DefaultPath implements \Magento\Framework\App\DefaultPathInterface
     */
    public function __construct(\Magento\Backend\App\ConfigInterface $config)
    {
-        $pathParts = explode('/', $config->getValue('web/default/admin'));
+        $pathParts = explode('/', $config->getValue('web/default/admin') ?? '');


will if statement be more elegant for this case?

fascinosum · 2021-11-03T22:02:15Z

app/code/Magento/Backend/view/adminhtml/templates/widget/tabshoriz.phtml

@@ -19,7 +19,7 @@ use Magento\Framework\View\Helper\SecureHtmlRenderer;
    <?php foreach ($tabs as $_tab): ?>
        <?php $tabId = $block->getTabId($_tab) ?>
        <?php $_tabClass = 'tab-item-link ' . $block->getTabClass($_tab) . ' ' .
-            (preg_match('/\s?ajax\s?/', $_tab->getClass()) ? 'notloaded' : '') ?>
+            (preg_match('/\s?ajax\s?/', $_tab->getClass() ?? '') ? 'notloaded' : '') ?>


Should it be fixed in \Magento\Backend\Block\Widget\Tabs::getTabClass intead?

@fascinosum the problem is in a method 'getClass', and $_tab can be a DataObject

fascinosum · 2021-11-03T22:06:58Z

app/code/Magento/Shipping/Model/Simplexml/Element.php

@@ -20,6 +20,7 @@ class Element extends \Magento\Framework\Simplexml\Element
     * @param string $namespace If specified, the namespace to which the attribute belongs.
     * @return void
     */
+    #[\ReturnTypeWillChange]


this is a non-API class, we can add appropriate return types

karyna-t · 2021-11-04T11:26:41Z

@magento run all tests with env PHP 7.4

magento-automated-testing · 2021-11-04T11:26:49Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-11-17T07:56:58Z

Closed due to this pull request has been divided by separated PRs (34637, 34638, 34640, 34641)

magento-automated-testing · 2021-11-22T23:40:30Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Fix Return Type deprecation notcies

2bc0f35

magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 2, 2021

m2-community-project bot added Progress: pending review labels Nov 2, 2021

andrewbess self-assigned this Nov 2, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Nov 2, 2021

andrewbess added the Project: Platform Health label Nov 2, 2021

karyna-t force-pushed the php8.1-compatibility/fixes-to-launch-magento branch from 4f34fd4 to 64fc7fb Compare November 3, 2021 11:49

fascinosum reviewed Nov 3, 2021

View reviewed changes

m2-community-project bot assigned fascinosum Nov 3, 2021

fascinosum reviewed Nov 3, 2021

View reviewed changes

Magento 8.1 fixes

4f3979b

karyna-t force-pushed the php8.1-compatibility/fixes-to-launch-magento branch from 64fc7fb to 4f3979b Compare November 4, 2021 11:12

karyna-t added 2 commits November 15, 2021 13:05

fixes after CR

e5fe4a6

add fix for the Driver/File

dfb295c

karyna-t force-pushed the php8.1-compatibility/fixes-to-launch-magento branch from 02f938a to dfb295c Compare November 15, 2021 15:47

andrewbess closed this Nov 17, 2021

m2-community-project bot removed the Progress: review label Nov 17, 2021

karyna-t deleted the php8.1-compatibility/fixes-to-launch-magento branch November 26, 2021 22:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes to launch Magento with PHP 8.1 #34506

Fixes to launch Magento with PHP 8.1 #34506

karyna-t commented Nov 2, 2021 •

edited

Loading

m2-assistant bot commented Nov 2, 2021

fascinosum Nov 3, 2021

karyna-t Nov 4, 2021

fascinosum Nov 3, 2021

karyna-t Nov 4, 2021

fascinosum Nov 3, 2021

fascinosum Nov 3, 2021

karyna-t Nov 4, 2021

fascinosum Nov 3, 2021

karyna-t commented Nov 4, 2021

magento-automated-testing bot commented Nov 4, 2021

andrewbess commented Nov 17, 2021

magento-automated-testing bot commented Nov 22, 2021

Fixes to launch Magento with PHP 8.1 #34506

Fixes to launch Magento with PHP 8.1 #34506

Conversation

karyna-t commented Nov 2, 2021 • edited Loading

Description (*)

Related Pull Requests

Fixed Issues

Contribution checklist (*)

m2-assistant bot commented Nov 2, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

karyna-t commented Nov 4, 2021

magento-automated-testing bot commented Nov 4, 2021

andrewbess commented Nov 17, 2021

magento-automated-testing bot commented Nov 22, 2021

karyna-t commented Nov 2, 2021 •

edited

Loading