Skip to content

Fixes to launch Magento with PHP 8.1 - part 2 #34638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 22, 2021
Merged

Fixes to launch Magento with PHP 8.1 - part 2 #34638

merged 3 commits into from
Nov 22, 2021

Conversation

karyna-t
Copy link
Contributor

@karyna-t karyna-t commented Nov 15, 2021 •
edited
Loading

Description (*)

Fixes for compatibility with PHP 8.1 (to be able to launch Magento)
Part 2

Related Pull Requests

Related Issues

  1. Add fixes Magento to run on PHP 8.1 #34505

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-github-services m2-github-services added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 15, 2021
@karyna-t karyna-t changed the title [WIP] Fixes to launch Magento with PHP 8.1 - part 2 Fixes to launch Magento with PHP 8.1 - part 2 Nov 15, 2021
@andrewbess andrewbess added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: Platform Health labels Nov 15, 2021
@andrewbess andrewbess self-assigned this Nov 15, 2021
@xmav
Copy link
Contributor

xmav commented Nov 15, 2021

@mageto run Static Tests, Semantic Version Checker

2 similar comments
@karyna-t
Copy link
Contributor Author

@mageto run Static Tests, Semantic Version Checker

@andrewbess
Copy link
Contributor

@mageto run Static Tests, Semantic Version Checker

@andrewbess andrewbess changed the base branch from platform-health to 2.4-develop November 16, 2021 17:54
@andrewbess andrewbess changed the base branch from 2.4-develop to platform-health November 16, 2021 17:54
@andrewbess andrewbess mentioned this pull request Nov 17, 2021
Closed
5 tasks
@xmav
Copy link
Contributor

xmav commented Nov 17, 2021

@magento run all tests with env PHP 8.1

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@xmav
Copy link
Contributor

xmav commented Nov 18, 2021

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@xmav
Copy link
Contributor

xmav commented Nov 18, 2021

@magento run Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t karyna-t force-pushed the fix-magento-to-launch-with-php8.1-part2 branch from 605f873 to a6315ec Compare November 18, 2021 09:42
andrewbess
andrewbess approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @karyna-tsymbal-atwix
Thank you for your work here.
Approved ✔️

@andrewbess
Copy link
Contributor

@magento run Static Tests with env PHP 8.1

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t
Copy link
Contributor Author

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess
Copy link
Contributor

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess
Copy link
Contributor

Hello @karyna-tsymbal-atwix
Could you please fix Static Tests?
Thank you in advance.

@karyna-t
Copy link
Contributor Author

@andrewbess tests were fixed except the "Comment block is missing" warning. This requires to update Magento Coding Standards to ignore #[\ReturnTypeWillChange] after the docblock.

@karyna-t
Copy link
Contributor Author

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@xmav
Copy link
Contributor

xmav commented Nov 19, 2021

@magento run Static Tests, Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@xmav
Copy link
Contributor

xmav commented Nov 22, 2021

All tests will be re-checked during delivery to 2.4-develop

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 1e7fdb7 into magento:platform-health Nov 22, 2021
@karyna-t karyna-t deleted the fix-magento-to-launch-with-php8.1-part2 branch November 26, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmav xmav xmav left review comments

@andrewbess andrewbess andrewbess approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@xmav xmav

@andrewbess andrewbess

Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: review Project: Platform Health
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@karyna-t @xmav @andrewbess @ihor-sviziev @magento-devops-reposync-svc @m2-github-services