WIP: Return non-secure URL if explicitly requested #9719
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Zifius is there anything I an do to help here? |
|
@miguelbalparda yeah, got quite busy to be able to continue on it right now. Would you like to connect via Skype and work together? |
|
@okorshenko Please unassign, unfortunately I don't have time atm, I spoke with Miguel though and can offer further help in testing / reviewing |
|
Closing this PR due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Take _secure => false flag into account before checking if the request is secure
Fixed Issues
#6175: Unable to generate unsecure URL if current URL is secure
Manual testing scenarios
Contribution checklist