Skip to content

Mapbase v7.3 #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 84 commits into from
Jan 17, 2025
Merged

Mapbase v7.3 #354

merged 84 commits into from
Jan 17, 2025

Conversation

Blixibon
Copy link
Member

@Blixibon Blixibon commented Jan 11, 2025

Small to medium-sized update which mainly aims to merge overdue PRs and fix issues.

...which is exactly what Mapbase v7.2's description was, although I've done some extra vetting to ensure that previous saves are compatible.

As before, my intention is to wait until Mapbase v8.0 before including save-breaking changes, most importantly #221. I don't intend to let things drag on this time.


samisalreadytaken and others added 30 commits December 17, 2023 18:47
Out of bounds array index corrupting the stack
This function is used to color impact particles.
On Linux I've noticed that this function sometimes is not successful on
retrieving the surface color, leaving an odd color to render the
particles with. The engine function TraceLineMaterialAndLighting() even
has a boolean return value indicating success.
GetModelMaterialColorAndLighting() does not though, but I still observe
failures (the color parameter is not modified). The color is initialized
with an invalid value. If it detects that retrieving the color failed
(engine function said so or the invalid value was left in place), this
now hamfistedly assumes a lightish grey color, but at least still
correctly (presumably) incorporates lighting information.
When this situation is detected, a warning is also printed to the
console. Because why not.
…Data()

GCC warns about attempting to delete a void-pointer, since it will not
be able to invoke its destructor. Fix by casing it to the expected
type.
Crashes on Linux. Apparently returns incorrect values on Windows.
Wikot235 and others added 22 commits January 5, 2025 16:13
[FIX] Undefined behaviour on comparison of NaN and float at particlemgr.cpp
Add random spawn type for env_headcrabcanister
Added a new ConVar that allows trigger_changelevel to be triggered by MOVETYPE_NOCLIP
…hook, VScript proxies not cleaning up correctly
@Blixibon Blixibon marked this pull request as ready for review January 11, 2025 21:50
@Blixibon Blixibon merged commit ab6dbb8 into master Jan 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
10 participants