Skip to content

Upgrade android gradle plugin and gradle versions. #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

epool
Copy link
Contributor

@epool epool commented Jan 3, 2019

Fixes #137

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@epool
Copy link
Contributor Author

epool commented Jan 3, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@willlarche willlarche merged commit 03efb44 into material-components:101-starter Jan 4, 2019
@willlarche
Copy link
Collaborator

Thank you!!!

willlarche added a commit that referenced this pull request Mar 25, 2019
[101] Making AppBar something you add in 102.

[Model] Adding model from the start.

[103] Adding fonts.

[103] Supplemental files.

[101] Correcting supplemental files.

[101] Copy correction.

[101] Minor renaming.

[101] Update for Dart 2.

[101] Missing dependency.

[101] Dart 2.

[101] Dart 2.

[101] Dart 2.

[101] Dart 2.

[101] Correcting model.

[Meta] README file.

[Meta] Clarification.

[101] Copy correction.

[104] Updating data.

[101] Correcting widget class. (#23)

Add link to actual codelab in the README

[Meta] README correction.

[101] README specificity.

Add the slanted_menu.png to assets for 101 branch so its ready when needed. (#44)

[101] TODOs for starter code (#50)

[101] Added future TODOs to 101 starter

[101] Included lines to ignore .iml files and files in idea/ (#67)

[101] Remove 104 comments

[All] Icons for Android and iOS. (#69)

[101] Add .vscode/ to gitignore, stop tracking ignored files (#71)

Removes files that should not be tracked because they've been ignored by gitignore rules (but have yet to be removed from the repository itself). Also adds the .vscode folder to gitignore, for users who might use VSCode as their development environment.

[101] Removed legacy 'new' and 'const' from 101 starter codelab (#72)

[101] Restore legacy to data.dart and product.dart (#75)

[101] Update import for app.dart to stop type errors in future codelabs (#83)

Replace data.dart (#99)

[All] Adding back in filter functionality. (#112)

[106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" (#115)

* [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride"

* [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride"

[101] Starter code.

issue #134

[101] Updating pubspec.

Upgrade android gradle plugin and gradle versions. (#143)

Fixes #137
rami-a pushed a commit that referenced this pull request Apr 24, 2019
[101] Making AppBar something you add in 102.

[Model] Adding model from the start.

[103] Adding fonts.

[103] Supplemental files.

[101] Correcting supplemental files.

[101] Copy correction.

[101] Minor renaming.

[101] Update for Dart 2.

[101] Missing dependency.

[101] Dart 2.

[101] Dart 2.

[101] Dart 2.

[101] Dart 2.

[101] Correcting model.

[Meta] README file.

[Meta] Clarification.

[101] Copy correction.

[104] Updating data.

[101] Correcting widget class. (#23)

Add link to actual codelab in the README

[Meta] README correction.

[101] README specificity.

Add the slanted_menu.png to assets for 101 branch so its ready when needed. (#44)

[101] TODOs for starter code (#50)

[101] Added future TODOs to 101 starter

[101] Included lines to ignore .iml files and files in idea/ (#67)

[101] Remove 104 comments

[All] Icons for Android and iOS. (#69)

[101] Add .vscode/ to gitignore, stop tracking ignored files (#71)

Removes files that should not be tracked because they've been ignored by gitignore rules (but have yet to be removed from the repository itself). Also adds the .vscode folder to gitignore, for users who might use VSCode as their development environment.

[101] Removed legacy 'new' and 'const' from 101 starter codelab (#72)

[101] Restore legacy to data.dart and product.dart (#75)

[101] Update import for app.dart to stop type errors in future codelabs (#83)

Replace data.dart (#99)

[All] Adding back in filter functionality. (#112)

[106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" (#115)

* [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride"

* [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride"

[101] Starter code.

issue #134

[101] Updating pubspec.

Upgrade android gradle plugin and gradle versions. (#143)

Fixes #137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants