-
Notifications
You must be signed in to change notification settings - Fork 248
[All] Replace data.dart with product_repository.dart. #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
michdud
merged 1 commit into
material-components:101-starter
from
michdud:fix-replace-data
Aug 23, 2018
Merged
[All] Replace data.dart with product_repository.dart. #99
michdud
merged 1 commit into
material-components:101-starter
from
michdud:fix-replace-data
Aug 23, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR should also update where it's called. |
Oh, wait. There aren't any at 101. Please make PRs for the others then :) |
willlarche
approved these changes
Aug 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow with PRs for calling this method.
michdud
pushed a commit
to michdud/material-components-flutter-codelabs
that referenced
this pull request
Aug 23, 2018
[101] Making AppBar something you add in 102. [Model] Adding model from the start. [103] Adding fonts. [103] Supplemental files. [101] Correcting supplemental files. [101] Copy correction. [101] Minor renaming. [101] Update for Dart 2. [101] Missing dependency. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Correcting model. [Meta] README file. [Meta] Clarification. [101] Copy correction. [104] Updating data. [101] Correcting widget class. (material-components#23) Add link to actual codelab in the README [Meta] README correction. [101] README specificity. Add the slanted_menu.png to assets for 101 branch so its ready when needed. (material-components#44) [101] TODOs for starter code (material-components#50) [101] Added future TODOs to 101 starter [101] Included lines to ignore .iml files and files in idea/ (material-components#67) [101] Remove 104 comments [All] Icons for Android and iOS. (material-components#69) [101] Add .vscode/ to gitignore, stop tracking ignored files (material-components#71) Removes files that should not be tracked because they've been ignored by gitignore rules (but have yet to be removed from the repository itself). Also adds the .vscode folder to gitignore, for users who might use VSCode as their development environment. [101] Removed legacy 'new' and 'const' from 101 starter codelab (material-components#72) [101] Restore legacy to data.dart and product.dart (material-components#75) [101] Update import for app.dart to stop type errors in future codelabs (material-components#83) Replace data.dart (material-components#99)
michdud
pushed a commit
to michdud/material-components-flutter-codelabs
that referenced
this pull request
Aug 23, 2018
[101] Making AppBar something you add in 102. [Model] Adding model from the start. [103] Adding fonts. [103] Supplemental files. [101] Correcting supplemental files. [101] Copy correction. [101] Minor renaming. [101] Update for Dart 2. [101] Missing dependency. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Correcting model. [Meta] README file. [Meta] Clarification. [101] Copy correction. [104] Updating data. [101] Correcting widget class. (material-components#23) Add link to actual codelab in the README [Meta] README correction. [101] README specificity. Add the slanted_menu.png to assets for 101 branch so its ready when needed. (material-components#44) [101] TODOs for starter code (material-components#50) [101] Added future TODOs to 101 starter [101] Included lines to ignore .iml files and files in idea/ (material-components#67) [101] Remove 104 comments [All] Icons for Android and iOS. (material-components#69) [101] Add .vscode/ to gitignore, stop tracking ignored files (material-components#71) Removes files that should not be tracked because they've been ignored by gitignore rules (but have yet to be removed from the repository itself). Also adds the .vscode folder to gitignore, for users who might use VSCode as their development environment. [101] Removed legacy 'new' and 'const' from 101 starter codelab (material-components#72) [101] Restore legacy to data.dart and product.dart (material-components#75) [101] Update import for app.dart to stop type errors in future codelabs (material-components#83) Replace data.dart (material-components#99)
michdud
pushed a commit
to michdud/material-components-flutter-codelabs
that referenced
this pull request
Aug 24, 2018
[101] Making AppBar something you add in 102. [Model] Adding model from the start. [103] Adding fonts. [103] Supplemental files. [101] Correcting supplemental files. [101] Copy correction. [101] Minor renaming. [101] Update for Dart 2. [101] Missing dependency. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Correcting model. [Meta] README file. [Meta] Clarification. [101] Copy correction. [104] Updating data. [101] Correcting widget class. (material-components#23) Add link to actual codelab in the README [Meta] README correction. [101] README specificity. Add the slanted_menu.png to assets for 101 branch so its ready when needed. (material-components#44) [101] TODOs for starter code (material-components#50) [101] Added future TODOs to 101 starter [101] Included lines to ignore .iml files and files in idea/ (material-components#67) [101] Remove 104 comments [All] Icons for Android and iOS. (material-components#69) [101] Add .vscode/ to gitignore, stop tracking ignored files (material-components#71) Removes files that should not be tracked because they've been ignored by gitignore rules (but have yet to be removed from the repository itself). Also adds the .vscode folder to gitignore, for users who might use VSCode as their development environment. [101] Removed legacy 'new' and 'const' from 101 starter codelab (material-components#72) [101] Restore legacy to data.dart and product.dart (material-components#75) [101] Update import for app.dart to stop type errors in future codelabs (material-components#83) Replace data.dart (material-components#99)
willlarche
added a commit
that referenced
this pull request
Sep 6, 2018
[101] Making AppBar something you add in 102. [Model] Adding model from the start. [103] Adding fonts. [103] Supplemental files. [101] Correcting supplemental files. [101] Copy correction. [101] Minor renaming. [101] Update for Dart 2. [101] Missing dependency. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Correcting model. [Meta] README file. [Meta] Clarification. [101] Copy correction. [104] Updating data. [101] Correcting widget class. (#23) Add link to actual codelab in the README [Meta] README correction. [101] README specificity. Add the slanted_menu.png to assets for 101 branch so its ready when needed. (#44) [101] TODOs for starter code (#50) [101] Added future TODOs to 101 starter [101] Included lines to ignore .iml files and files in idea/ (#67) [101] Remove 104 comments [All] Icons for Android and iOS. (#69) [101] Add .vscode/ to gitignore, stop tracking ignored files (#71) Removes files that should not be tracked because they've been ignored by gitignore rules (but have yet to be removed from the repository itself). Also adds the .vscode folder to gitignore, for users who might use VSCode as their development environment. [101] Removed legacy 'new' and 'const' from 101 starter codelab (#72) [101] Restore legacy to data.dart and product.dart (#75) [101] Update import for app.dart to stop type errors in future codelabs (#83) Replace data.dart (#99) [All] Adding back in filter functionality. (#112) [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" (#115) * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride"
willlarche
added a commit
that referenced
this pull request
Mar 25, 2019
[101] Making AppBar something you add in 102. [Model] Adding model from the start. [103] Adding fonts. [103] Supplemental files. [101] Correcting supplemental files. [101] Copy correction. [101] Minor renaming. [101] Update for Dart 2. [101] Missing dependency. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Correcting model. [Meta] README file. [Meta] Clarification. [101] Copy correction. [104] Updating data. [101] Correcting widget class. (#23) Add link to actual codelab in the README [Meta] README correction. [101] README specificity. Add the slanted_menu.png to assets for 101 branch so its ready when needed. (#44) [101] TODOs for starter code (#50) [101] Added future TODOs to 101 starter [101] Included lines to ignore .iml files and files in idea/ (#67) [101] Remove 104 comments [All] Icons for Android and iOS. (#69) [101] Add .vscode/ to gitignore, stop tracking ignored files (#71) Removes files that should not be tracked because they've been ignored by gitignore rules (but have yet to be removed from the repository itself). Also adds the .vscode folder to gitignore, for users who might use VSCode as their development environment. [101] Removed legacy 'new' and 'const' from 101 starter codelab (#72) [101] Restore legacy to data.dart and product.dart (#75) [101] Update import for app.dart to stop type errors in future codelabs (#83) Replace data.dart (#99) [All] Adding back in filter functionality. (#112) [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" (#115) * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" [101] Starter code. issue #134 [101] Updating pubspec. Upgrade android gradle plugin and gradle versions. (#143) Fixes #137
willlarche
added a commit
that referenced
this pull request
Mar 25, 2019
[101] Making AppBar something you add in 102. [Model] Adding model from the start. [103] Adding fonts. [103] Supplemental files. [101] Correcting supplemental files. [101] Copy correction. [101] Minor renaming. [101] Update for Dart 2. [101] Missing dependency. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Correcting model. [Meta] README file. [Meta] Clarification. [101] Copy correction. [104] Updating data. [101] Correcting widget class. (#23) Add link to actual codelab in the README [Meta] README correction. [101] README specificity. Add the slanted_menu.png to assets for 101 branch so its ready when needed. (#44) [101] TODOs for starter code (#50) [101] Added future TODOs to 101 starter [101] Included lines to ignore .iml files and files in idea/ (#67) [101] Remove 104 comments [All] Icons for Android and iOS. (#69) [101] Add .vscode/ to gitignore, stop tracking ignored files (#71) Removes files that should not be tracked because they've been ignored by gitignore rules (but have yet to be removed from the repository itself). Also adds the .vscode folder to gitignore, for users who might use VSCode as their development environment. [101] Removed legacy 'new' and 'const' from 101 starter codelab (#72) [101] Restore legacy to data.dart and product.dart (#75) [101] Update import for app.dart to stop type errors in future codelabs (#83) Replace data.dart (#99) [All] Adding back in filter functionality. (#112) [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" (#115) * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" [101] Completed code. [103] Correcting cut corners file. [102] Updating pubspec. [101] Completed code.
willlarche
added a commit
that referenced
this pull request
Mar 25, 2019
[101] Making AppBar something you add in 102. [Model] Adding model from the start. [103] Adding fonts. [103] Supplemental files. [101] Correcting supplemental files. [101] Copy correction. [101] Minor renaming. [101] Update for Dart 2. [101] Missing dependency. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Correcting model. [Meta] README file. [Meta] Clarification. [101] Copy correction. [104] Updating data. [101] Correcting widget class. (#23) Add link to actual codelab in the README [Meta] README correction. [101] README specificity. Add the slanted_menu.png to assets for 101 branch so its ready when needed. (#44) [101] TODOs for starter code (#50) [101] Added future TODOs to 101 starter [101] Included lines to ignore .iml files and files in idea/ (#67) [101] Remove 104 comments [All] Icons for Android and iOS. (#69) [101] Add .vscode/ to gitignore, stop tracking ignored files (#71) Removes files that should not be tracked because they've been ignored by gitignore rules (but have yet to be removed from the repository itself). Also adds the .vscode folder to gitignore, for users who might use VSCode as their development environment. [101] Removed legacy 'new' and 'const' from 101 starter codelab (#72) [101] Restore legacy to data.dart and product.dart (#75) [101] Update import for app.dart to stop type errors in future codelabs (#83) Replace data.dart (#99) [All] Adding back in filter functionality. (#112) [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" (#115) * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" [101] Completed code. [103] Correcting cut corners file. [102] Updating pubspec. [102] Completed code. [101] Making AppBar something you add in 102. [Model] Adding model from the start. [103] Adding fonts. [103] Supplemental files. [101] Correcting supplemental files. [101] Copy correction. [101] Minor renaming. [101] Update for Dart 2. [101] Missing dependency. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Correcting model. [Meta] README file. [Meta] Clarification. [101] Copy correction. [104] Updating data. [101] Correcting widget class. (#23) Add link to actual codelab in the README [Meta] README correction. [101] README specificity. Add the slanted_menu.png to assets for 101 branch so its ready when needed. (#44) [101] TODOs for starter code (#50) [101] Added future TODOs to 101 starter [101] Included lines to ignore .iml files and files in idea/ (#67) [101] Remove 104 comments [All] Icons for Android and iOS. (#69) [101] Add .vscode/ to gitignore, stop tracking ignored files (#71) Removes files that should not be tracked because they've been ignored by gitignore rules (but have yet to be removed from the repository itself). Also adds the .vscode folder to gitignore, for users who might use VSCode as their development environment. [101] Removed legacy 'new' and 'const' from 101 starter codelab (#72) [101] Restore legacy to data.dart and product.dart (#75) [101] Update import for app.dart to stop type errors in future codelabs (#83) Replace data.dart (#99) [All] Adding back in filter functionality. (#112) [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" (#115) * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" [101] Completed code. [102] Completed code. [103] Correcting cut corners border file. [102] ClipBehavior. [103] Updating pubspec
willlarche
added a commit
that referenced
this pull request
Mar 25, 2019
[101] Making AppBar something you add in 102. [Model] Adding model from the start. [103] Adding fonts. [103] Supplemental files. [101] Correcting supplemental files. [101] Copy correction. [101] Minor renaming. [101] Update for Dart 2. [101] Missing dependency. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Correcting model. [Meta] README file. [Meta] Clarification. [101] Copy correction. [104] Updating data. [101] Correcting widget class. (#23) Add link to actual codelab in the README [Meta] README correction. [101] README specificity. Add the slanted_menu.png to assets for 101 branch so its ready when needed. (#44) [101] TODOs for starter code (#50) [101] Added future TODOs to 101 starter [101] Included lines to ignore .iml files and files in idea/ (#67) [101] Remove 104 comments [All] Icons for Android and iOS. (#69) [101] Add .vscode/ to gitignore, stop tracking ignored files (#71) Removes files that should not be tracked because they've been ignored by gitignore rules (but have yet to be removed from the repository itself). Also adds the .vscode folder to gitignore, for users who might use VSCode as their development environment. [101] Removed legacy 'new' and 'const' from 101 starter codelab (#72) [101] Restore legacy to data.dart and product.dart (#75) [101] Update import for app.dart to stop type errors in future codelabs (#83) Replace data.dart (#99) [All] Adding back in filter functionality. (#112) [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" (#115) * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" [101] Completed code. [102] Completed code. [103] Completed code. 104 starter (#136) * Fix default BorderSide in CutCornersBorder constructor issue #134 * Miscellaneous fixes - Fix login button color (issue #133) - Restore obscureText on password field (issue #127) - Fix AccentColorOverride (issue #128, #132) [103] Button theme fix. [104] Updating pubspec [103] Completed code.
willlarche
added a commit
that referenced
this pull request
Mar 25, 2019
[101] Making AppBar something you add in 102. [Model] Adding model from the start. [103] Adding fonts. [103] Supplemental files. [101] Correcting supplemental files. [101] Copy correction. [101] Minor renaming. [101] Update for Dart 2. [101] Missing dependency. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Correcting model. [Meta] README file. [Meta] Clarification. [101] Copy correction. [104] Updating data. [101] Correcting widget class. (#23) Add link to actual codelab in the README [Meta] README correction. [101] README specificity. Add the slanted_menu.png to assets for 101 branch so its ready when needed. (#44) [101] TODOs for starter code (#50) [101] Added future TODOs to 101 starter [101] Included lines to ignore .iml files and files in idea/ (#67) [101] Remove 104 comments [All] Icons for Android and iOS. (#69) [101] Add .vscode/ to gitignore, stop tracking ignored files (#71) Removes files that should not be tracked because they've been ignored by gitignore rules (but have yet to be removed from the repository itself). Also adds the .vscode folder to gitignore, for users who might use VSCode as their development environment. [101] Removed legacy 'new' and 'const' from 101 starter codelab (#72) [101] Restore legacy to data.dart and product.dart (#75) [101] Update import for app.dart to stop type errors in future codelabs (#83) Replace data.dart (#99) [All] Adding back in filter functionality. (#112) [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" (#115) * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" [101] Completed code. [102] Completed code. [103] Completed code. [104] Completed code. Bump shrine_images to 1.1.1 (#138) [103] Correcting cut corners border file. [103-4] Button theme.
rami-a
pushed a commit
to rami-a/material-components-flutter-codelabs
that referenced
this pull request
Apr 8, 2019
[101] Making AppBar something you add in 102. [Model] Adding model from the start. [103] Adding fonts. [103] Supplemental files. [101] Correcting supplemental files. [101] Copy correction. [101] Minor renaming. [101] Update for Dart 2. [101] Missing dependency. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Correcting model. [Meta] README file. [Meta] Clarification. [101] Copy correction. [104] Updating data. [101] Correcting widget class. (material-components#23) Add link to actual codelab in the README [Meta] README correction. [101] README specificity. Add the slanted_menu.png to assets for 101 branch so its ready when needed. (material-components#44) [101] TODOs for starter code (material-components#50) [101] Added future TODOs to 101 starter [101] Included lines to ignore .iml files and files in idea/ (material-components#67) [101] Remove 104 comments [All] Icons for Android and iOS. (material-components#69) [101] Add .vscode/ to gitignore, stop tracking ignored files (material-components#71) Removes files that should not be tracked because they've been ignored by gitignore rules (but have yet to be removed from the repository itself). Also adds the .vscode folder to gitignore, for users who might use VSCode as their development environment. [101] Removed legacy 'new' and 'const' from 101 starter codelab (material-components#72) [101] Restore legacy to data.dart and product.dart (material-components#75) [101] Update import for app.dart to stop type errors in future codelabs (material-components#83) Replace data.dart (material-components#99) [All] Adding back in filter functionality. (material-components#112) [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" (material-components#115) * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" [101] Completed code. [102] Completed code. [103] Completed code. [104] Completed code. Bump shrine_images to 1.1.1 (material-components#138) [103] Correcting cut corners border file. [103-4] Button theme.
rami-a
pushed a commit
that referenced
this pull request
Apr 8, 2019
[101] Making AppBar something you add in 102. [Model] Adding model from the start. [103] Adding fonts. [103] Supplemental files. [101] Correcting supplemental files. [101] Copy correction. [101] Minor renaming. [101] Update for Dart 2. [101] Missing dependency. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Correcting model. [Meta] README file. [Meta] Clarification. [101] Copy correction. [104] Updating data. [101] Correcting widget class. (#23) Add link to actual codelab in the README [Meta] README correction. [101] README specificity. Add the slanted_menu.png to assets for 101 branch so its ready when needed. (#44) [101] TODOs for starter code (#50) [101] Added future TODOs to 101 starter [101] Included lines to ignore .iml files and files in idea/ (#67) [101] Remove 104 comments [All] Icons for Android and iOS. (#69) [101] Add .vscode/ to gitignore, stop tracking ignored files (#71) Removes files that should not be tracked because they've been ignored by gitignore rules (but have yet to be removed from the repository itself). Also adds the .vscode folder to gitignore, for users who might use VSCode as their development environment. [101] Removed legacy 'new' and 'const' from 101 starter codelab (#72) [101] Restore legacy to data.dart and product.dart (#75) [101] Update import for app.dart to stop type errors in future codelabs (#83) Replace data.dart (#99) [All] Adding back in filter functionality. (#112) [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" (#115) * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" [101] Completed code. [102] Completed code. [103] Completed code. [104] Completed code. Bump shrine_images to 1.1.1 (#138) [103] Correcting cut corners border file. [103-4] Button theme.
rami-a
pushed a commit
that referenced
this pull request
Apr 24, 2019
[101] Making AppBar something you add in 102. [Model] Adding model from the start. [103] Adding fonts. [103] Supplemental files. [101] Correcting supplemental files. [101] Copy correction. [101] Minor renaming. [101] Update for Dart 2. [101] Missing dependency. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Dart 2. [101] Correcting model. [Meta] README file. [Meta] Clarification. [101] Copy correction. [104] Updating data. [101] Correcting widget class. (#23) Add link to actual codelab in the README [Meta] README correction. [101] README specificity. Add the slanted_menu.png to assets for 101 branch so its ready when needed. (#44) [101] TODOs for starter code (#50) [101] Added future TODOs to 101 starter [101] Included lines to ignore .iml files and files in idea/ (#67) [101] Remove 104 comments [All] Icons for Android and iOS. (#69) [101] Add .vscode/ to gitignore, stop tracking ignored files (#71) Removes files that should not be tracked because they've been ignored by gitignore rules (but have yet to be removed from the repository itself). Also adds the .vscode folder to gitignore, for users who might use VSCode as their development environment. [101] Removed legacy 'new' and 'const' from 101 starter codelab (#72) [101] Restore legacy to data.dart and product.dart (#75) [101] Update import for app.dart to stop type errors in future codelabs (#83) Replace data.dart (#99) [All] Adding back in filter functionality. (#112) [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" (#115) * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" * [106] Update TODO from "PrimaryColorOverride" to "AccentColorOverride" [101] Starter code. issue #134 [101] Updating pubspec. Upgrade android gradle plugin and gradle versions. (#143) Fixes #137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.