Utilities: Add GeoJSON Handling #13268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR restructures shape file handling by consolidating functionality from the Shape module into the Geo module and adds GeoJSON support. The changes prepare the codebase for GeoJSON handling while maintaining existing KML and SHP file support.
- Moves shape file handling classes from
src/Utilities/Shape/tosrc/Utilities/Geo/ - Adds new GeoJSON helper classes for reading and writing GeoJSON format files
- Updates JsonHelper to support GeoJSON coordinate format alongside existing coordinate handling
Reviewed Changes
Copilot reviewed 18 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Utilities/Geo/GeoJsonHelper.h |
New header defining GeoJSON file handling interface |
src/Utilities/Geo/GeoJsonHelper.cc |
Implementation of GeoJSON parsing and coordinate conversion |
src/Utilities/JsonHelper.h |
Updated coordinate functions to support GeoJSON format |
src/Utilities/JsonHelper.cc |
Refactored coordinate handling with unified implementation |
src/Utilities/Geo/CMakeLists.txt |
Added GeoJSON sources and moved shape file sources from Shape module |
src/Utilities/Geo/ShapeFileHelper.* |
Moved from Shape module with logging category updates |
src/Utilities/Geo/SHPFileHelper.* |
Moved from Shape module with parameter name consistency |
src/Utilities/Geo/KMLHelper.* |
Moved from Shape module with parameter name consistency |
src/Utilities/Geo/KMLDomDocument.* |
Moved from Shape module with include reorganization |
test/Utilities/Geo/CMakeLists.txt |
Added shape test files moved from Shape module |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the interface, not yet implemented into plans. Would be replaced by GDAL if I had that working