Skip to content

Discontinue support for old PHP versions #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rjelierse opened this issue Jan 21, 2019 · 4 comments · Fixed by #108
Closed

Discontinue support for old PHP versions #79

rjelierse opened this issue Jan 21, 2019 · 4 comments · Fixed by #108

Comments

@rjelierse
Copy link
Contributor

As you can see from the list of supported versions, most of the versions we're still actively supporting are no longer supported by PHP itself. It might be time to drop support for these versions and update to use language features that are only available on later versions (e.g. type hinting of scalars). Older versions of this package will still be available to those that insist of running on ancient PHP versions, but they would be excluded from new functionality onwards.

@chrisminett
Copy link
Contributor

A v2 of this package could achieve so much enhancement, like these PHP versions, a cleaner HTTP client #39 , and making objects immutable.

@chrisminett
Copy link
Contributor

It seems that updates to this package are done mainly through contributor PRs - I guess that Messagebird don't use PHP themselves, so there isn't much drive to improve the code quality and get a v2 out.

Perhaps one of the maintainers could create a v2.x branch, so that we might create PRs against that and start getting some improvements in, eg:

  • Drop PHP 5.x
  • Use Guzzle as the HTTP client rather than re-inventing it
  • Remove the mutable objects (everything is public in Base, there's no constructor, no validation or validation can be skipped)

@webmaster777
Copy link

webmaster777 commented Jun 7, 2019

You should use HTTPlug rather than confining to Guzzle. See http://httplug.io/

@webmaster777
Copy link

A v2 of this package could achieve so much enhancement, like these PHP versions, a cleaner HTTP client #39 , and making objects immutable.

Dropping php version support would not necessarily require a v2 (https://www.doctrine-project.org/2017/07/25/php-7.1-requirement-and-composer.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants