Update PHPUnit to 8.x and drop unsupported versions #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolobueno
force-pushed
the
phpunit-8
branch
3 times, most recently
from
5c3a6a1 to
cad21c0
Compare
paolobueno
changed the title
felipecoppola
suggested changes
Jan 8, 2020
| "php": ">=5.4.0", | ||
| "ext-curl": "*", | ||
| "symfony/polyfill-php56": "^1.10" | ||
| "php": ">=7.2.0", |
There was a problem hiding this comment.
:)
BTW from #79 (comment) this could be published as a minor version bump and let composer's php version resolution to avoid having users of unsupported versions upgrade.
There was a problem hiding this comment.
This should be updated in the README, it still says php >= 5.4
|
@felipecoppola addressed comments, can you take another look when you have the chance? |
felipecoppola
approved these changes
Jan 8, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #98
Closes #79
PHPUnit 4.x is pretty ancient, and on recent versions it runs into this issue with invoking a fully deprecated method.
It seems that tests in Travis have not been running in 7.x for a while as well.
Composer also does not support HHVM, so I've removed it from the matrix as well.
Changes
Notes
I'm not sure if there's a requirement to keep support for 5.x (supported until late 2018). PHPUnit only supported 5.6 until PHPUnit 5.x, supported until early 2018.